DietPi-Software | Pi-hole: Whitelist GEO IP API we use in banner and DietPi-VPN

[MichaIng]

Status: Ready

Commit list/description:

• DietPi-Patches | Pi-hole: Whitelist domain of GEO IP API we use in banner and DietPi-VPN as this is part of public blocklists
• DietPi-Software | Pi-hole: Whitelist domain of GEO IP API we use in banner and DietPi-VPN as this is part of public blocklists

[Joulinar]

We will do this without user notification?

[ravenclaw900]

It would probably be good to at least put a comment for that entry, but I don’t think that you can do it from the command line.

[Joulinar]

technically it's working

root@DietPiProd:~# pihole -w freegeoip.app
  [i] Adding freegeoip.app to the whitelist...
  [✓] Reloading DNS lists
root@DietPiProd:~#

WAN IP is now being detected

- WAN IP : 93.x.x.x Region Germany

[MichaIng]

We will do this without user notification?

The pihole command prints nicely what is done, but I added another notification about why we do it 👍.

It would probably be good to at least put a comment for that entry, but I don’t think that you can do it from the command line.

I didn't know about those comments and they can be added via CLI as well, which I've added now 👍.

Great is also that existing entries are gracefully replaced by the command, so no problem in running the same command multiple times, on reinstalls or when applying the DietPi update multiple times during beta phase and such.

[MichaIng]

# Pi-hole install
[ INFO ] DietPi-Software | Whitelisting "freegeoip.app", which is used by dietpi-banner and dietpi-vpn to obtain your public IP and location...
  [i] Adding freegeoip.app to the whitelist...
  [✓] Reloading DNS lists
...
# DietPi update
[ INFO ] DietPi-Patch | Whitelisting "freegeoip.app" in Pi-hole, which is used by dietpi-banner and dietpi-vpn to obtain your public IP and location...
  [i] freegeoip.app already exists in whitelist, no need to add!

Very nice, I'm gonna merge it.