Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solving the issued #78 #79

Closed
wants to merge 2 commits into from
Closed

Solving the issued #78 #79

wants to merge 2 commits into from

Conversation

codeswithroh
Copy link
Contributor

As mentioned in #78 that choosing templates becomes extremely hard for the user or new contributors who just want to see what type of templates are present.

Proposed Solution

I added a section which will consists of screenshots of every theme with mobile and desktop view along with its name and the name of contributor.

Here is my solution

  • This is how it is going to look after merging my PR

linkfree

  • For a better view you can check the Readme.md of my forked repo

@codeswithroh
Copy link
Contributor Author

@MichaelBarney Do I need to change anything to my pr or was this idea not relatable for your project?

@MichaelBarney
Copy link
Owner

Hi Rohit! Thanks for your proposal. However, due to it being a manual process, I believe it will be hard to maintain for this repository.

@codeswithroh
Copy link
Contributor Author

Yes very true. But since a lot of people want to contribute and if 5 people add 10 templates each which will hardly take a minute or two then it will be much easier. And yes messing up the template for the Readme file is quite easy and it will be really hard for you to check if the proper style is maintained or not. But if you are interested in automating this process, then I can dive into Github Actions which will check for the proper template of the ReadMe when someone makes a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants