Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new space theme with responsiveness and tailwindCSS. #97

Merged
merged 4 commits into from
Oct 3, 2022

Conversation

Mohit-Aasirwal
Copy link
Contributor

#3 new space theme with dynamic moon background and made with tailwindCSS library. Kindly consider it for merging on 1st October under hacktoberfest 2022.

Copy link
Contributor

@what-a-time what-a-time left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for your PR!
node_modules shouldn't be committed in this case. Not only do they bloat the PR and make it hard to review it, they also aren't needed at all. Everyone can install the dependencies with npm install when needed.
Your .vscode directory shouldn't be committed, either. I recommend adding a .gitignore file that includes both directories to solve this.

@MichaelBarney
Copy link
Owner

As Noevenzahn pointed out, please change the PR to not include .vscode and node_modules.

@Mohit-Aasirwal
Copy link
Contributor Author

I've added gitignore file.
please merge the new theme now.

@MichaelBarney
Copy link
Owner

Even though you added the gitignore, the files are still added to the commit. Please review the added files for the PR to be accepted.

@Mohit-Aasirwal
Copy link
Contributor Author

OK! I think now it is implemented. You can merge now.
I enjoyed contributing to this repo
Gracias!

@MichaelBarney MichaelBarney merged commit 1dad219 into MichaelBarney:master Oct 3, 2022
@MichaelBarney
Copy link
Owner

Perfect!

@Mohit-Aasirwal
Copy link
Contributor Author

please label this PR as hacktoberfest accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants