Skip to content

Commit

Permalink
Merge pull request #5 from Azure/master
Browse files Browse the repository at this point in the history
Merge Main to fork
  • Loading branch information
MichalHel authored Nov 29, 2020
2 parents 241faf7 + 33b5733 commit 87082fb
Show file tree
Hide file tree
Showing 1,449 changed files with 144,786 additions and 4,223 deletions.
12 changes: 0 additions & 12 deletions .azure-pipelines/Avocado.yml

This file was deleted.

15 changes: 0 additions & 15 deletions .azure-pipelines/LintDiff.yml

This file was deleted.

13 changes: 0 additions & 13 deletions .azure-pipelines/ModelValidation.yml

This file was deleted.

13 changes: 0 additions & 13 deletions .azure-pipelines/Semantic.yml

This file was deleted.

5 changes: 5 additions & 0 deletions .github/comment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,3 +23,8 @@
type: label
label: Approved-OkToMerge
onLabeledComments: "Hi @${PRAuthor},Your PR is approved. Congratulations. </br> <li> If your PR is in public repo (azure-rest-api-specs), PR assignee will merge all updates in the PR shortly afterwards; or pause the PR merge, you need to put on a label <b>DoNotMerge</b> to PR as soon as possible. </li><li>If your PR is in private repo (azure-rest-api-specs-pr), there won’t be PR merge. Please refer to this [wiki](https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/205/RP-Scenarios-to-Contribute-to-Swagger?anchor=**public-repository-vs.-private-repository**) for further guidance on how to proceed. </li>"

- rule:
type: label
label: NewApiVersionRequired
onLabeledComments: "<b>NewApiVersionRequired reason:</b></br> </br><b>A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support. </b> </br></br> EXAMPLE: if a customer calls a service in the public cloud using <b>api-version=2020-07-27</b>, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features. "
45 changes: 25 additions & 20 deletions .github/pull_request_assignment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,24 @@
- kairu-ms

- rule:
paths: "specification/@(resources|powerplatform)/**"
paths: "specification/@(resources|powerplatform|appplatform)/**"
reviewers:
- raych1

- rule:
paths: "specification/sql/**"
reviewers:
- akning-ms

- rule:
paths: "specification/signalr/**"
reviewers:
- leni-msft

- rule:
paths: "specification/eventhub/**"
reviewers:
- ruowan
- rule:
paths: "specification/compute/**"
reviewers:
Expand All @@ -57,7 +71,7 @@

- rule:
paths:
- "specification/@(azureactivedirectory|appplatform)/**"
- "specification/azureactivedirectory/**"
reviewers:
- njuCZ

Expand Down Expand Up @@ -136,33 +150,23 @@

- rule:
paths:
- "**/package.json"
- ".github/**"
- "**/azure-pipelines.yml"
- ".azure-pipelines/**"
- ".azure-pipelines-preproduction/**"
- "documentation/**"
reviewers:
- josefree
- akning-ms
- PhoenixHe-msft

- rule:
paths:
- "documentation/**"
reviewers:
- josefree
- akning-ms

- rule:
paths:
- rule:
paths:
- "**/package.json"
- ".github/**"
- "**/azure-pipelines.yml"
- ".azure-pipelines/**"
- ".azure-pipelines-preproduction/**"
reviewers:
- akning-ms
- PhoenixHe-msft
reviewers:
- akning-ms
- PhoenixHe-msft
- raych1
- zhenglaizhang

- rule:
# manager-plane PR
Expand All @@ -185,3 +189,4 @@
- qianwens
- ruowan
- jianyexi
- zhenglaizhang
4 changes: 0 additions & 4 deletions azure-pipelines.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,6 @@ variables:
jobs:
- template: .azure-pipelines/BranchProtectionForPrivateRepo.yml
- template: .azure-pipelines/Syntax.yml
- template: .azure-pipelines/Semantic.yml
- template: .azure-pipelines/Avocado.yml
- template: .azure-pipelines/ModelValidation.yml
- template: .azure-pipelines/LintDiff.yml
- template: .azure-pipelines/NetworkValidation.yml
- template: .azure-pipelines/Spellcheck.yml
- template: .azure-pipelines/PrettierCheck.yml
8 changes: 8 additions & 0 deletions cSpell.json
Original file line number Diff line number Diff line change
Expand Up @@ -748,6 +748,14 @@
"pstn",
"unconfiguring"
]
},
{
"filename": "**/specification/saas/resource-manager/Microsoft.SaaS/preview/2018-03-01-beta/saas.json",
"words": [
"checkmoderneligibility",
"saasresources",
"Moderneligibility"
]
}
]
}
Loading

0 comments on commit 87082fb

Please sign in to comment.