What is the correct return type for mixins? (simple case)

[onadeemdev]

Hi when we use mixins what is the correct return type for the function? I am trying to properly define it but could use some help, as somewhat new to TS. Does this look correct?

type EmailMixinReturnType<TClassType extends ClassType> = new (
  ...args: ConstructorParameters<TClassType>
) => InstanceType<TClassType> & { email: string }

const EmailMixin = <TClassType extends ClassType>(BaseClass: TClassType): EmailMixinReturnType<TClassType> => {
  @InputType('EmailInput')
  class EmailInput extends BaseClass {
    @Field()
    email: string
  }
  return EmailInput
}

export default EmailMixin

[MichalLytek]

Why do you want to define the type? You should rely on type inference.

[onadeemdev]

It's for curiosity, I am using a TS project that requires defining the function return type. I can disable the line but would also just like to know to help me improve with TS. Thanks!

…

On Wed, Mar 29, 2023 at 2:16 AM Michał Lytek ***@***.***> wrote: Why do you want to define the type? You should rely on type inference. — Reply to this email directly, view it on GitHub <#1436 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AYKHYEUIR6JHPOTKWB2L6EDW6PHT7ANCNFSM6AAAAAAWLPXBTU> . You are receiving this because you authored the thread.Message ID: ***@***.*** com>

[MichalLytek]

Honestly, I have no idea. This lint rules only make things worse for such cases like mixins.

[onadeemdev]

ah ok thanks anyway!