Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix not registering object types when interface type is used as object type field type #736

Merged
merged 2 commits into from
Oct 23, 2020

Conversation

MichalLytek
Copy link
Owner

Closes #726 🔒

@MichalLytek MichalLytek added the Bugfix 🐛 🔨 PR that fixes a known bug label Oct 20, 2020
@MichalLytek MichalLytek added this to the 1.x versions milestone Oct 20, 2020
@MichalLytek MichalLytek self-assigned this Oct 20, 2020
@codecov
Copy link

codecov bot commented Oct 20, 2020

Codecov Report

Merging #736 into master will decrease coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #736      +/-   ##
==========================================
- Coverage   95.40%   95.33%   -0.07%     
==========================================
  Files          80       80              
  Lines        1479     1480       +1     
  Branches      294      294              
==========================================
  Hits         1411     1411              
- Misses         65       66       +1     
  Partials        3        3              
Impacted Files Coverage Δ
src/schema/schema-generator.ts 97.68% <100.00%> (-0.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9566b08...59f42eb. Read the comment docs.

@MichalLytek MichalLytek merged commit bd4f261 into master Oct 23, 2020
@MichalLytek MichalLytek deleted the fix-implements-auto-register branch October 23, 2020 18:05
@MichalLytek MichalLytek modified the milestones: 1.x versions, 1.2 Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix 🐛 🔨 PR that fixes a known bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interface implementations are missing
1 participant