Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement MqDockerUp Self-Update #9

Open
MichelFR opened this issue Feb 25, 2023 · 1 comment
Open

Implement MqDockerUp Self-Update #9

MichelFR opened this issue Feb 25, 2023 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@MichelFR
Copy link
Owner

I have identified an issue with MqDockerUp that prevents it from being able to update itself. The problem is that when we update the docker container, it pulls the newest image, stops and removes the container, but is not able to reach the code to create a new container with the newly pulled image.

To solve this issue, I propose creating a separate project named "MqDockerUp-Update" with a separate docker image that binds to the docker.sock to pull the newest image, stop and remove the MqDockerUp container, and create a new docker container instance. I believe this is a better approach than creating the new container before deleting the old one, which may cause problems and needs to be tested first.

I welcome contributions and would be happy to hear if someone has a better idea on how to solve this issue. It would be beneficial to avoid having two instances of the same image running, which is why I think having a separate project named "MqDockerUp-Update" for updating MqDockerUp is a good solution. To implement this feature, I will need to code and test it. This issue is being raised to track the progress of implementing the MqDockerUp self-update feature.

@MichelFR MichelFR added enhancement New feature or request help wanted Extra attention is needed labels Feb 25, 2023
MichelFR added a commit that referenced this issue Feb 25, 2023
@MichelFR MichelFR pinned this issue Mar 8, 2023
@realcanadrian
Copy link

Why not have it create a Watchtower container with a one-time run command to update the MqDockerUp container? I think that's actually what Watchtower does to update itself.

MichelFR added a commit that referenced this issue Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants