Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat history management #207

Merged
merged 5 commits into from
May 14, 2024

Conversation

calderonsamuel
Copy link
Collaborator

Related issue

Description of changes

  • Conversation titles are built using the first user prompt for the conversation
  • Every received message updates the chat history saved in disk. There is no option to opt out of this, but users can easily delete their conversations (setting the option was too difficult for the backend).

For contributors

  • I have added the relevant changes to the NEWS.md file
  • I have added relevant tests or documentation with my changes

For reviewers

  • [] Changes meet the acceptance criteria of the related issue
  • [] The contribution follows style conventions and code of conduct
  • [] Branch passes automated testing
  • [] I have incremented the package version in the DESCRIPTION file before merging

@calderonsamuel calderonsamuel requested a review from JamesHWade May 13, 2024 22:29
@calderonsamuel calderonsamuel linked an issue May 13, 2024 that may be closed by this pull request
3 tasks
Copy link
Collaborator

@JamesHWade JamesHWade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

This is making me want to incorporate some sort of performance benchmarks. I doubt it's true in this case, but it would be nice to know if we're degrading performance of the app when we incorporate new features.

@JamesHWade JamesHWade merged commit 44ee5d7 into main May 14, 2024
8 checks passed
@calderonsamuel calderonsamuel deleted the 202-fr-set-save-chat-conversation-option-in-settings branch May 14, 2024 01:10
@calderonsamuel
Copy link
Collaborator Author

This would totally decrease performance once the chat history is big enough. Might be worth it to use an internal sqlite db?

The sidebar UI will also get clutered with a high number of chats. We should have a "See more" functionality for saved chats.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR]: Set save chat conversation option in settings
2 participants