Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

213 bug chat in source gives chatgpt responded message when im not using the openai service #214

Merged
merged 8 commits into from
Jun 3, 2024
Merged

213 bug chat in source gives chatgpt responded message when im not using the openai service #214

merged 8 commits into from
Jun 3, 2024

Conversation

calderonsamuel
Copy link
Collaborator

@calderonsamuel calderonsamuel commented Jun 2, 2024 •
edited by JamesHWade
Loading

Related issue

Description of changes

  • Fixed a bug that showed the message "ChatGPT responded" even when other service was being used in "Chat in source" related addins.
  • Moved "in source" logic to addin file and did some cleanup

For contributors

  • I have added the relevant changes to the NEWS.md file
  • I have added relevant tests or documentation with my changes

For reviewers

  • Changes meet the acceptance criteria of the related issue
  • The contribution follows style conventions and code of conduct
  • Branch passes automated testing
  • I have incremented the package version in the DESCRIPTION file before merging

@calderonsamuel calderonsamuel linked an issue Jun 2, 2024 that may be closed by this pull request
[Bug]: Chat in source gives "ChatGPT responded" message when I'm not using the OpenAI service #213
Closed
3 tasks
JamesHWade
JamesHWade approved these changes Jun 3, 2024
View reviewed changes
Copy link
Collaborator

@JamesHWade JamesHWade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. I'll go ahead and merge.

@JamesHWade JamesHWade merged commit 38e8301 into main Jun 3, 2024
10 checks passed
@calderonsamuel calderonsamuel deleted the 213-bug-chat-in-source-gives-chatgpt-responded-message-when-im-not-using-the-openai-service branch June 3, 2024 13:58
@calderonsamuel
Copy link
Collaborator Author

Please don't forget to go trough the reviewer checklist 🙏 We need to increment the dev version

@JamesHWade
Copy link
Collaborator

Thanks for the reminder!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesHWade JamesHWade JamesHWade approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Chat in source gives "ChatGPT responded" message when I'm not using the OpenAI service
2 participants
@calderonsamuel @JamesHWade