Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] add gpt-4o-mini and set as default #220

Merged
merged 3 commits into from
Jul 22, 2024
Merged

[feat] add gpt-4o-mini and set as default #220

merged 3 commits into from
Jul 22, 2024

Conversation

JamesHWade
Copy link
Collaborator

@JamesHWade JamesHWade commented Jul 21, 2024 •
edited
Loading

Related issue

Description of changes

  • Update gpt-4o-mini as default model and update test accordingly.

For contributors

  • I have added the relevant changes to the NEWS.md file
  • I have added relevant tests or documentation with my changes

For reviewers

  • [] Changes meet the acceptance criteria of the related issue
  • [] The contribution follows style conventions and code of conduct
  • [] Branch passes automated testing
  • [] I have incremented the package version in the DESCRIPTION file before merging

calderonsamuel
calderonsamuel reviewed Jul 22, 2024
View reviewed changes
tests/testthat/test-models.R
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the tests

calderonsamuel
calderonsamuel approved these changes Jul 22, 2024
View reviewed changes
Copy link
Collaborator

@calderonsamuel calderonsamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@calderonsamuel calderonsamuel merged commit e652bd3 into main Jul 22, 2024
8 checks passed
@calderonsamuel calderonsamuel deleted the gpt4o-mini branch July 22, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calderonsamuel calderonsamuel calderonsamuel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set gpt4o mini as default for openai
2 participants
@JamesHWade @calderonsamuel