⏹️ Fix the 'Stop Orders' button behavior #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updates: - [github.com/commitizen-tools/commitizen: v2.39.1 → v2.40.0](commitizen-tools/commitizen@v2.39.1...v2.40.0)
…base table add Flags table to database add set_flag and get_flag support functions adapt __init__.py and core.py to use the new Flags table delete flags when cleaning tables
clean_tables now set the no_more_orders flag to false instead of removing every row from the table get_flag check if the query returns None before setting the value (this avoid masking False values with None)
…tizen-action to 0.16.1 fix a bug with commitizen-action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
The Stop Orders button used
pn.state.cacheto store a status flag, but its value is not shared among web app instances behind an Nginx server. Activating the Stop Orders button affected only the instance where the command is issued.The status flag (named
no_more_orders) is now stored in a dedicatedflagstable inside the database and shared among every web app instance.CI
Change conditions that trigger the workflow
release_new_version.yamland update commitizen-action to 0.16.1 (see commitizen-action#56).Closes #47