Re-organise browserify transform #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move babelify transform out of browserify key in package.json. This change is due to an error on deploy when requiring this module from a project that uses a newer version of babel. This error is due to an incompatability in the babelrc referencing an old key that isn't used by babel 6. Since this project exports the babel-ified version in the dist/ folder, there isn't any need to run browserify or babelify over the code when using it as a dependency in another project. Add npmignore file to slim down production release. This file will ignore any files not needed to use this module as a dependency.
bassjacob
changed the title
| @@ -1,13 +1,14 @@ | |||
| { | |||
| "name": "react-gmaps", | |||
| "version": "1.2.2", | |||
| "name": "@subshad/react-gmaps", | |||
There was a problem hiding this comment.
Just de-own the package and we are ready to go :)
There was a problem hiding this comment.
Whoops, I thought I commited that after I opened this. I'll de-own it now :)
|
Thank you very much @subshad |
|
I think that should do it. Sorry about the naming commit |
MicheleBertoli
added a commit
that referenced
this pull request
Feb 5, 2016
Re-organise browserify transform
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move babelify transform out of browserify key in package.json. This
change is due to an error on deploy when requiring this module from a
project that uses a newer version of babel. This error is due to an
incompatability in the babelrc referencing an old key that isn't used by
babel 6.
Since this project exports the babel-ified version in the dist/ folder,
there isn't any need to run browserify or babelify over the code when using
it as a dependency in another project.
Add npmignore file to slim down production release. This file will ignore
any files not needed to use this module as a dependency.