Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secondary sinks should receive object similar to the one received by primary sink #993

Merged
merged 9 commits into from
Nov 13, 2018
Merged

Secondary sinks should receive object similar to the one received by primary sink #993

merged 9 commits into from
Nov 13, 2018

Conversation

RamjotSingh
Copy link
Contributor

@RamjotSingh RamjotSingh commented Nov 10, 2018

Fix Issue #992
Adds code to clone the properties in TelemetryContext as well when DeepClone is called. Also fixed missing TimeStamp clone when dealing with PageViewTelemetry.

For significant contributions please make sure you have completed the following items:

  • Design discussion issue #
  • Changes in public surface reviewed
  • CHANGELOG.md updated with one line description of the fix, and a link to the original issue.
  • The PR will trigger build, unit test, and functional tests automatically. If your PR was submitted from fork - mention one of committers to initiate the build for you.

@RamjotSingh RamjotSingh changed the title Telemetry context DeepClone should clone all the properties. Secondary sinks should receive object similar to the one received by primary sink Nov 10, 2018
@RamjotSingh
Copy link
Contributor Author

@SergeyKanzhelev , @cijothomas Please trigger build.

Copy link
Contributor

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cijothomas
Copy link
Contributor

@RamjotSingh There are build failures due to minor fx/style cops. Can you run locally in Release mode to see the failures.

@cijothomas cijothomas closed this Nov 13, 2018
@cijothomas cijothomas reopened this Nov 13, 2018
@cijothomas cijothomas closed this Nov 13, 2018
@cijothomas cijothomas reopened this Nov 13, 2018
@cijothomas cijothomas merged commit d453526 into microsoft:develop Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants