-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Secondary sinks should receive object similar to the one received by primary sink #993
Merged
cijothomas
merged 9 commits into
microsoft:develop
from
RamjotSingh:ramjot/develop-TelemetryContextDeepClone
Nov 13, 2018
Merged
Secondary sinks should receive object similar to the one received by primary sink #993
cijothomas
merged 9 commits into
microsoft:develop
from
RamjotSingh:ramjot/develop-TelemetryContextDeepClone
Nov 13, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RamjotSingh
changed the title
Telemetry context DeepClone should clone all the properties.
Secondary sinks should receive object similar to the one received by primary sink
Nov 10, 2018
@SergeyKanzhelev , @cijothomas Please trigger build. |
cijothomas
approved these changes
Nov 13, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@RamjotSingh There are build failures due to minor fx/style cops. Can you run locally in Release mode to see the failures. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Issue #992
Adds code to clone the properties in TelemetryContext as well when DeepClone is called. Also fixed missing TimeStamp clone when dealing with PageViewTelemetry.
For significant contributions please make sure you have completed the following items: