Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not render certain activity types in webchat #1363

Merged
merged 2 commits into from
Mar 10, 2019
Merged

do not render certain activity types in webchat #1363

merged 2 commits into from
Mar 10, 2019

Conversation

a-b-r-o-w-n
Copy link
Contributor

@a-b-r-o-w-n a-b-r-o-w-n commented Mar 8, 2019 •
edited
Loading

fixes #1358

Fixed

  • [client] Do not render certain activities in webchat in PR #1363

@a-b-r-o-w-n a-b-r-o-w-n marked this pull request as ready for review March 8, 2019 21:39
@coveralls
Copy link

coveralls commented Mar 8, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 2178

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 54.977%
Totals Coverage Status
Change from base Build 2173: 0.01%
Covered Lines: 4873
Relevant Lines: 8324
💛 - Coveralls

@cwhitten cwhitten merged commit 7c49920 into microsoft:master Mar 10, 2019
@a-b-r-o-w-n a-b-r-o-w-n deleted the webchat-do-not-render-trace branch March 11, 2019 15:05
justinwilaby added a commit that referenced this pull request Mar 11, 2019
@justinwilaby
Fixes #1363 Native dialogs no longer display
68f25ff
cwhitten pushed a commit that referenced this pull request Mar 11, 2019
@cwhitten
Fixes #1283 - opening a bot that has moved should show a message (#1360)
00f263e 
* Fixes #1283 - opening a bot that has moved should show a message

* Linting fix

* Moved imports back to proper location

* Lint

* Fixes #1363 Native dialogs no longer display
@cwhitten cwhitten mentioned this pull request Apr 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwhitten cwhitten cwhitten approved these changes

@compulim compulim Awaiting requested review from compulim

@corinagum corinagum Awaiting requested review from corinagum

@justinwilaby justinwilaby Awaiting requested review from justinwilaby

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WebChat tries to render all activity types
3 participants
@a-b-r-o-w-n @coveralls @cwhitten