Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow all private declarations to be emitted in declaration output #23351

Merged
merged 8 commits into from
May 10, 2018
Merged

Allow all private declarations to be emitted in declaration output #23351

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
37458de
Mostly functional WIP
weswigham Apr 11, 2018
4ed36d4
Fix accessors, symbol stringification
weswigham Apr 11, 2018
0d0931d
Accept/update changed baselines
weswigham Apr 11, 2018
4bfefba
Move type definition so file build order doesnt matter
weswigham Apr 11, 2018
098c0ab
Merge branch 'master' into allow-other-private-declarations
weswigham Apr 11, 2018
0a75ecb
Accept post-merge test update
weswigham Apr 11, 2018
aa71540
Merge branch 'master' into allow-other-private-declarations
weswigham May 3, 2018
2e6e6ee
Rename function, add doc
weswigham May 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 65 additions & 7 deletions src/compiler/checker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2822,6 +2822,11 @@ namespace ts {
isDeclarationVisible(declaration.parent.parent.parent)) {
return addVisibleAlias(declaration, declaration.parent.parent);
}
else if (isLateVisibilityPaintedStatement(declaration) // unexported top-level statement
&& !hasModifier(declaration, ModifierFlags.Export)
&& isDeclarationVisible(declaration.parent)) {
return addVisibleAlias(declaration, declaration);
}

// Declaration is not visible
return false;
Expand Down Expand Up @@ -3679,7 +3684,14 @@ namespace ts {
return typeParameterNodes;
}

function symbolToTypeNode(symbol: Symbol, context: NodeBuilderContext, meaning: SymbolFlags): TypeQueryNode | TypeReferenceNode | ImportTypeNode {
function getAccessTypeSplitNode(top: IndexedAccessTypeNode): IndexedAccessTypeNode {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does getAccessTypeSplitNode mean? The name is quite opaque, so a doc comment would be helpful.

if (isIndexedAccessTypeNode(top.objectType)) {
return getAccessTypeSplitNode(top.objectType);
}
return top;
}

function symbolToTypeNode(symbol: Symbol, context: NodeBuilderContext, meaning: SymbolFlags): TypeNode {
const chain = lookupSymbolChain(symbol, context, meaning);

context.flags |= NodeBuilderFlags.InInitialEntityName;
Expand All @@ -3689,15 +3701,26 @@ namespace ts {
const isTypeOf = meaning === SymbolFlags.Value;
if (ambientModuleSymbolRegex.test(rootName)) {
// module is root, must use `ImportTypeNode`
const nonRootParts = chain.length > 1 ? createEntityNameFromSymbolChain(chain, chain.length - 1, 1) : undefined;
const nonRootParts = chain.length > 1 ? createAccessFromSymbolChain(chain, chain.length - 1, 1) : undefined;
const typeParameterNodes = lookupTypeParameterNodes(chain, 0, context);
return createImportTypeNode(createLiteralTypeNode(createLiteral(rootName.substring(1, rootName.length - 1))), nonRootParts, typeParameterNodes as ReadonlyArray<TypeNode>, isTypeOf);
const lit = createLiteralTypeNode(createLiteral(rootName.substring(1, rootName.length - 1)));
if (!nonRootParts || isEntityName(nonRootParts)) {
return createImportTypeNode(lit, nonRootParts as EntityName, typeParameterNodes as ReadonlyArray<TypeNode>, isTypeOf);
}
else {
const splitNode = getAccessTypeSplitNode(nonRootParts);
const qualifier = (splitNode.objectType as TypeReferenceNode).typeName;
return createIndexedAccessTypeNode(createImportTypeNode(lit, qualifier, typeParameterNodes as ReadonlyArray<TypeNode>, isTypeOf), splitNode.indexType);
}
}

const entityName = createEntityNameFromSymbolChain(chain, chain.length - 1, 0);
const entityName = createAccessFromSymbolChain(chain, chain.length - 1, 0);
if (isIndexedAccessTypeNode(entityName)) {
return entityName; // Indexed accesses can never be `typeof`
}
return isTypeOf ? createTypeQueryNode(entityName) : createTypeReferenceNode(entityName, /*typeArguments*/ undefined);

function createEntityNameFromSymbolChain(chain: Symbol[], index: number, stopper: number): EntityName {
function createAccessFromSymbolChain(chain: Symbol[], index: number, stopper: number): EntityName | IndexedAccessTypeNode {
const typeParameterNodes = lookupTypeParameterNodes(chain, index, context);
const symbol = chain[index];

Expand All @@ -3708,10 +3731,30 @@ namespace ts {
if (index === 0) {
context.flags ^= NodeBuilderFlags.InInitialEntityName;
}

const parent = chain[index - 1];
if (parent && getMembersOfSymbol(parent) && getMembersOfSymbol(parent).get(symbol.escapedName) === symbol) {
// Should use an indexed access
const LHS = createAccessFromSymbolChain(chain, index - 1, stopper);
if (isIndexedAccessTypeNode(LHS)) {
return createIndexedAccessTypeNode(LHS, createLiteralTypeNode(createLiteral(symbolName)));
}
else {
return createIndexedAccessTypeNode(createTypeReferenceNode(LHS, typeParameterNodes as ReadonlyArray<TypeNode>), createLiteralTypeNode(createLiteral(symbolName)));
}
}

const identifier = setEmitFlags(createIdentifier(symbolName, typeParameterNodes), EmitFlags.NoAsciiEscaping);
identifier.symbol = symbol;

return index > stopper ? createQualifiedName(createEntityNameFromSymbolChain(chain, index - 1, stopper), identifier) : identifier;
if (index > stopper) {
const LHS = createAccessFromSymbolChain(chain, index - 1, stopper);
if (!isEntityName(LHS)) {
return Debug.fail("Impossible construct - an export of an indexed access cannot be reachable");
}
return createQualifiedName(LHS, identifier);
}
return identifier;
}
}

Expand Down Expand Up @@ -26566,7 +26609,22 @@ namespace ts {
const symbol = node && getSymbolOfNode(node);
return !!(symbol && getCheckFlags(symbol) & CheckFlags.Late);
},
getJsxFactoryEntity: location => location ? (getJsxNamespace(location), (getSourceFileOfNode(location).localJsxFactory || _jsxFactoryEntity)) : _jsxFactoryEntity
getJsxFactoryEntity: location => location ? (getJsxNamespace(location), (getSourceFileOfNode(location).localJsxFactory || _jsxFactoryEntity)) : _jsxFactoryEntity,
getAllAccessorDeclarations(accessor: AccessorDeclaration): AllAccessorDeclarations {
accessor = getParseTreeNode(accessor, isGetOrSetAccessorDeclaration);
const otherKind = accessor.kind === SyntaxKind.SetAccessor ? SyntaxKind.GetAccessor : SyntaxKind.SetAccessor;
const otherAccessor = getDeclarationOfKind<AccessorDeclaration>(getSymbolOfNode(accessor), otherKind);
const firstAccessor = otherAccessor && (otherAccessor.pos < accessor.pos) ? otherAccessor : accessor;
const secondAccessor = otherAccessor && (otherAccessor.pos < accessor.pos) ? accessor : otherAccessor;
const setAccessor = accessor.kind === SyntaxKind.SetAccessor ? accessor : otherAccessor;
const getAccessor = accessor.kind === SyntaxKind.GetAccessor ? accessor : otherAccessor;
return {
firstAccessor,
secondAccessor,
setAccessor,
getAccessor
};
}
};

function isInHeritageClause(node: PropertyAccessEntityNameExpression) {
Expand Down
Loading