Design assembly support for control library #1550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…embly # Conflicts: # Directory.Build.props
…embly (two-step proces now)
dotMorten
changed the title
|
@Oceanware Any chance the Design Time gury (that's you :-) would be interested in reviewing this one? AFAIK nothing about building design time experiences has really changed since you worked and blogged about it. I would love for this repo to be the reference implementation of improving design time experiences. |
|
Works as expected, but only on the legacy designer. When running on an app targeting the FCU and therefore using the new designer in VS 2017.4, the new categories or tooltips do not show up. |
|
@nmetulev Thanks for the fix. Works good here too |
nmetulev
approved these changes
Oct 26, 2017
| /// <summary> | ||
| /// Basic Controls category. | ||
| /// </summary> | ||
| public const string Toolkit = "UWP Toolkit"; |
There was a problem hiding this comment.
Should be UWP Community Toolkit
skendrot
approved these changes
Oct 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Adds improved design time experience by providing "hover" tooltip in the property grid, and places properties in the proper categories.
Example of what the MardownText looks like:
...before all these properties was all thrown into the "Misc" category. (ignore the typo in the screenshot - it has been fixed :-)
Most of the base framework originates from the Silverlight Toolkit. I then had this ported to the Callisto project, and now carried it over to the UWP Community Toolkit.
What is the current behavior?
All control properties are under Miscellaneous in the property grid.
PR Checklist
Please check if your PR fulfills the following requirements:
Above check-list does not apply - these are design-time only changes and does not affect runtime.
What is the new behavior?
Control properties are now grouped, and hovering on a property gives you the code summary as a tooltip.
It also puts in place the framework for providing toolbox icons for each control.
Does this PR introduce a breaking change?