SampleApp updates and more #1624

nmetulev · 2017-11-14T23:13:16Z

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[x] Code style update (formatting)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build or CI related changes
[ ] Documentation content changes
[x] Sample app changes
[ ] Other... Please describe:

PR Checklist

Please check if your PR fulfills the following requirements:

Tested code with current supported SDKs

What is the new behavior?

This PR introduces the following changes:

Updated Sample App with more fluent design touches such as animations and materials
Replaced icons with new and improved icons
Fixed sample app to always grab latest documentation from new docs repo (Discrepancy between the app and NuGet package. #1592)
Fixed formatting warnings in various packages
Fixed a bug with implicit animations crashing on 14393
Fixed minor bugs with sample app

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

… mode

Add Focus on Xaml Pivot Item Selection Add Tracking for Internal Monaco Editor Exceptions

Update Monaco.Editor to 0.4.0

michael-hawker

Approving to move things forward, couple of comments, but nothing critical. Though did you test on XBox?

michael-hawker · 2017-11-15T06:28:40Z

Microsoft.Toolkit.Uwp.SampleApp/Microsoft.Toolkit.Uwp.SampleApp.csproj

@@ -145,7 +145,7 @@
  </ItemGroup>
  <ItemGroup>
    <!-- A reference to the entire .Net Framework and Windows SDK are automatically included -->
-    <Content Include="Assets\Helpers.png" />
+    <Content Include="Assets\Helpers_old.png" />


What's old about this now? ;)

Can it be removed?

Yes, will removed

michael-hawker · 2017-11-15T06:30:34Z

Microsoft.Toolkit.Uwp.SampleApp/Package.appxmanifest

        <Extension Category="windows.backgroundTasks" EntryPoint="Microsoft.Toolkit.Uwp.Samples.BackgroundTasks.TestBackgroundTask">
          <BackgroundTasks>
            <Task Type="timer" />
          </BackgroundTasks>
        </Extension>
+        <uap:Extension Category="windows.protocol">


Reason this moved down?

It must have moved down when the I've created an appx for testing.

michael-hawker · 2017-11-15T06:33:20Z

Microsoft.Toolkit.Uwp.SampleApp/Common/XAMLHelper.cs

+
+namespace Microsoft.Toolkit.Uwp.SampleApp
+{
+    public static class XAMLHelper


Should this be AcrylicHelper? Would help in readability when used.

I had it named AcrylicHelper originaly, but I wanted to also add helpers for Reveal later on so renamed it to be more generic

Name should be XamlHelper

michael-hawker · 2017-11-15T06:48:42Z

Microsoft.Toolkit.Uwp.SampleApp/Controls/ExtendedHamburgerMenu.cs

+
+        public async Task StartSearch(string startingText = null)
+        {
+            if (_searchBox == null || _searchBox.Visibility == Visibility.Visible)


I think it'd be actually nice if you hit 'enter' in the blank searchbox that it shows all the controls (it does this if you type something and then hit backspace).

Did you get Shane to test these changes on the XBox?

Good idea, fixed. Tested it on Xbox too

Why not just show everything as soon as you click the search button and then filter down from there

Having the animation when filtering is very jarring. This should be disabled

skendrot · 2017-11-15T21:24:06Z

When using the app with a narrow width, the menu button is confusing. I don't expect the items to be scrollable. I would expect the items to be in a standard menu when clicking the button

skendrot · 2017-11-15T21:24:46Z

Found a bug when in narrow mode.

Open Menu
Click Controls (might have to click twice to get the menu to go away)

Notice the menu button is still rotated 90 degrees.

nmetulev · 2017-11-16T01:23:00Z

@skendrot, fixed the menu bug, good catch. Narrow view still needs improvement, will probably get that done for 2.2

windowstoolkitbot · 2017-11-16T01:26:04Z

This PR is linked to unclosed issues. Please check if one of these issues should be closed: #1539, #1592

nmetulev and others added 30 commits November 4, 2017 18:57

branched out for sampleapp improvements

188c185

moved to gridview for samples

f3bfa2e

Merge branch 'nmetulev/composition' into nmetulev/sampleapp

2554c1d

replaced new thumbnails

296cedc

Merge branch 'master' into nmetulev/sampleapp

9aaf728

acrylic test

516ce03

pass 1 of extracting samplepicker from shell

1dbba23

updated navigation animations

f46709d

fixed up documentation in sample app to point to docs repo in release…

021733d

… mode

added sampleapp hamburgermenu animations

a4be83c

cleaned up unused page

6a84573

added moreinfo flyout

0124758

fix for moreinfo details crashing the app

fa2c846

Merge branch 'nmetulev/composition' into nmetulev/sampleapp

f9429ff

updated moreinfo flyout

9984fca

Merge branch 'master' into nmetulev/sampleapp

0e92e5d

added acrylic and parallax to sample app

8b251de

added acrylic and parallax to sample app

efe4f42

added more implicit animations in sample and clean up

b3ccdb1

added new background image and few icons

7a28703

fixed up implicit sample

35f846b

fixed up implicit sample

0ffc30a

Update Monaco.Editor to 0.4.0

d929ea3

Add Focus on Xaml Pivot Item Selection Add Tracking for Internal Monaco Editor Exceptions

Track any internal errors in Monaco Editor Component (via nuget update)

f930bfc

Merge pull request #1617 from Microsoft/mhawker/monaco-update

aefc66a

Update Monaco.Editor to 0.4.0

Merge branch 'master' into nmetulev/sampleapp

05b7bc0

Added new icons for headeredcontrols

2092258

Merge branch 'master' into nmetulev/sampleapp

a98900b

updated landingpagelinks

e85ce61

update headers

bff2b68

azchohfi approved these changes Nov 14, 2017

View reviewed changes

michael-hawker approved these changes Nov 15, 2017

View reviewed changes

nmetulev added 3 commits November 15, 2017 10:45

merge master

f1a730a

merge master

76dce67

clean up and addressed pr comments

6e345f1

nmetulev added 2 commits November 15, 2017 17:12

improved serach flickering

70c08e6

merged master

0e9a854

nmetulev merged commit ae3771b into master Nov 16, 2017

nmetulev deleted the nmetulev/sampleapp branch November 16, 2017 01:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SampleApp updates and more #1624

SampleApp updates and more #1624

nmetulev commented Nov 14, 2017

michael-hawker left a comment

michael-hawker Nov 15, 2017

nmetulev Nov 15, 2017

michael-hawker Nov 15, 2017

nmetulev Nov 15, 2017

michael-hawker Nov 15, 2017

nmetulev Nov 15, 2017

skendrot Nov 15, 2017

michael-hawker Nov 15, 2017

nmetulev Nov 15, 2017

skendrot Nov 15, 2017

skendrot Nov 15, 2017

skendrot commented Nov 15, 2017

skendrot commented Nov 15, 2017 •

edited

Loading

nmetulev commented Nov 16, 2017

windowstoolkitbot commented Nov 16, 2017

SampleApp updates and more #1624

SampleApp updates and more #1624

Conversation

nmetulev commented Nov 14, 2017

PR Type

PR Checklist

What is the new behavior?

Does this PR introduce a breaking change?

Other information

michael-hawker left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

skendrot commented Nov 15, 2017

skendrot commented Nov 15, 2017 • edited Loading

nmetulev commented Nov 16, 2017

windowstoolkitbot commented Nov 16, 2017

skendrot commented Nov 15, 2017 •

edited

Loading