Fix XAML Connected Animation crash (fixes #1913). #1945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmetulev
approved these changes
Apr 6, 2018
skendrot
reviewed
Apr 6, 2018
|
It is supported. That's what this PR fixes. We were not sure that the fix would work when we created the bug, but with this fix it does. |
|
So it doesn't crash and does the animation properly? |
|
Exactly. |
skendrot
approved these changes
Apr 6, 2018
|
This PR is linked to unclosed issues. Please check if one of these issues should be closed: #1913 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1913
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The app crashes if there are two lists with the same instance of an object on one page and you add the xaml connected animations that animates the view to a different page.
This simple catch, avoids the app from crashing, if the item instances are the same.
What is the new behavior?
No crash.
PR Checklist
Please check if your PR fulfills the following requirements:
Other information