XAML Connected Animation crash if using two lists and *same instance* of an object on both lists #1913
Comments
|
Agree, this is not something that we can easily support. |
|
This issue seems inactive. It will automatically be closed in 14 days if there is no activity. |
|
Turns out it was easy... Just a try catch. \o/ |
7 tasks
OpportunityLiu
added a commit
to OpportunityLiu/UWPCommunityToolkit
that referenced
this issue
Apr 12, 2018
* Change the background color of items when they are added or removed * extract method for common logic * only need to go from the index the item was inserted/removed * Ignore items to the end of the list, we'll handle that in another method * unsubscribe from events and remove the list when it's been unloaded * move methods to the bottom below changed handlers * unsubscribe from all list events when it is unloaded * Inherit from HeaderedContentControl to remove duplicate properties * Change default StepFrequency to 1 to match Slider * Change sample to use a regular slider for StepFrequency * Added ItemContainerStyleSelector ItemContainerStyleSelector allows for code to change the ItemContainerStyle on the fly * Fix for NavigationView SelectedIndex Bug CommunityToolkit#1905 We would sometimes in error set the SelectedItem to null due to an issue with comparing to the com object from the MenuItems list. Now we do a safer check and avoid resetting the item if its the same, and if we gave a valid index avoid setting to null if we do fail. * Strectch the content of the expander header to allow for other content * Update PULL_REQUEST_TEMPLATE.md * Use the index from the arguments rather than getting it from the container * Get the proper command bar added * Extract command logic * Removing Moldavian * Add Initial HeaderStyle Property to Expander * Move Height of Expander Header into Template * Update Expander Docs * fixed relative links in docs * attempting to fix dependency issue * updated version of gitversioning * updated gitversioning version * revert msbuild.sdk.extras * Removed obsolete comment from build script * Remove duplicate compositeTransform.CenterY * Fixed a NullReferenceException in AdvancedCollectionView Filter When setting a filter, then resetting it to null, an exception occured. This has been fixed. * Fix crash (CommunityToolkit#1913).
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I'm submitting a...
Current behavior
If you have two ListViewBase's and both use the same Id (like when you use the same style for the connected animations props) and they share an instance of an object, when navigating to another page, we get an exception at:
https://github.com/Microsoft/UWPCommunityToolkit/blob/master/Microsoft.Toolkit.Uwp.UI.Animations/ConnectedAnimations/ConnectedAnimationHelper.cs#L69
This works fine if it you have two different instances of the items.
Expected behavior
This is not a scenario that we should support, but it should not crash, ever. A simple break after line 69 of ConnectedAnimationHelper.cs should fix it.
Environment
The text was updated successfully, but these errors were encountered: