Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge #1

Merged
merged 43 commits into from
Apr 12, 2018
Merged

Merge #1

merged 43 commits into from
Apr 12, 2018

Conversation

OpportunityLiu
Copy link
Owner

Issue: #

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Contains NO breaking changes

Other information

skendrot and others added 30 commits February 27, 2018 16:44
@skendrot
Change the background color of items when they are added or removed
9800f4a
@skendrot
extract method for common logic
f509f59
@skendrot
only need to go from the index the item was inserted/removed
2a8fb42
@skendrot
Ignore items to the end of the list, we'll handle that in another method
10bc325
@skendrot
unsubscribe from events and remove the list when it's been unloaded
c6e29be
@skendrot
move methods to the bottom below changed handlers
a23e7fc
@skendrot
unsubscribe from all list events when it is unloaded
5c4a588
@skendrot
Inherit from HeaderedContentControl to remove duplicate properties
a186ee4
@skendrot
Change default StepFrequency to 1 to match Slider
714302e
@skendrot
Change sample to use a regular slider for StepFrequency
364f239
@mashedkeyboard
Added ItemContainerStyleSelector
53eadf5 
ItemContainerStyleSelector allows for code to change the ItemContainerStyle on the fly
@michael-hawker
Fix for NavigationView SelectedIndex Bug #1905
c36ff1d 
We would sometimes in error set the SelectedItem to null due to an issue with comparing to the com object from the MenuItems list.

Now we do a safer check and avoid resetting the item if its the same, and if we gave a valid index avoid setting to null if we do fail.
@skendrot
Strectch the content of the expander header to allow for other content
b71b6a0
@nmetulev
Merge pull request #1897 from skendrot/ExpanderInheritance
a824cff 
Change Expander to Inherit from HeaderedContentControl
@azchohfi
Merge pull request #1898 from skendrot/DefaultStepFrequency
82d31ea 
Change default StepFrequency
@azchohfi
Merge pull request #1906 from Microsoft/michael-hawker/navviewextensi…
a1fb03e 
…onfix

Fix for NavigationView SelectedIndex Bug #1905
@nmetulev
Merge pull request #1907 from skendrot/ExpandExpanderHeader
0a157a7 
Strectch the content of the expander header to allow for other content
@nmetulev
Update PULL_REQUEST_TEMPLATE.md
122ac80
@skendrot
Use the index from the arguments rather than getting it from the cont…
21c69b7 
…ainer
@skendrot
Get the proper command bar added
864f205
@skendrot
Extract command logic
c3f8461
@skendrot
Merge pull request #1902 from mashedkeyboard/patch-1
6ed5e41 
Added ItemContainerStyleSelector to the MasterDetailsView ListView
@Odonno
Merge pull request #1852 from skendrot/AlternateColorInsert
5e7fb51 
Alternate color of items when items are added or removed
@nmetulev
Removing Moldavian
70ed808
@nmetulev
Merge pull request #1911 from skendrot/MasterDetailsCommandBars
3c58f1c 
Properly show the command bars
@michael-hawker
Add Initial HeaderStyle Property to Expander
b2c337f
@michael-hawker
Move Height of Expander Header into Template
5b7e1a2
@michael-hawker
Update Expander Docs
8ea1ee4
@nmetulev
fixed relative links in docs
7987bb0
@Odonno
Merge pull request #1918 from michael-hawker/mhawker/expander-header
66701e8 
Add HeaderStyle Property for Expander
nmetulev and others added 13 commits March 25, 2018 14:01
@nmetulev
attempting to fix dependency issue
bd1f492
@nmetulev
updated version of gitversioning
fbd5c8e
@nmetulev
updated gitversioning version
150b97e
@nmetulev
revert msbuild.sdk.extras
4b92646
@nmetulev
Removed obsolete comment from build script
08f75e2
@nmetulev
Merge pull request #1924 from Microsoft/nmetulev/build
24d961e 
Updating to latest nerdbank.gitversioning to resolve dependency issue
@ChrisShaoMeng
Remove duplicate compositeTransform.CenterY
5b267ab
@nmetulev
Merge pull request #1934 from ChrisShaoMeng/master
3f30bc6 
Remove duplicate compositeTransform.CenterY
@azchohfi
Merge pull request #1914 from Microsoft/nmetulev/mo
ae7a71c 
Removing Moldavian language from Bing service
@gaunts
Fixed a NullReferenceException in AdvancedCollectionView Filter
40fbb33 
When setting a filter, then resetting it to null,
an exception occured. This has been fixed.
@nmetulev
Merge pull request #1939 from gaunts/hotfix-advCollectionViewNullFilter
b9cdbdc 
Fixed a NullReferenceException in AdvancedCollectionView Filter
@azchohfi
Fix crash (#1913).
ca7895c
@skendrot
Merge pull request #1945 from Microsoft/avoidCrashConnectedAnims
db7ebf2 
Fix XAML Connected Animation crash (fixes #1913).
@OpportunityLiu OpportunityLiu merged commit 91e63e5 into OpportunityLiu:master Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@OpportunityLiu @skendrot @mashedkeyboard @michael-hawker @nmetulev @azchohfi @Odonno @ChrisShaoMeng @gaunts