[Fix] Negative index validation in TextBoxRegEx #2293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… value as it is when it is in position 0
nmetulev
approved these changes
Jul 11, 2018
skendrot
approved these changes
Jul 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #
#2221
PR Type
What kind of change does this PR introduce?
Bugfix
What is the current behavior?
This application crashes when you enter [1] [-] [left arrow] [Backspace] in a TextBoxRegEx, and its extensions are TextBoxRegex.ValidationType = "Decimal" and TextBoxRegex.ValidationMode="Dynamic". This happens because when you delete characters, the index goes back one position. When it reaches 0, it will return a negative value that will be passed to the remove call, and therefore, this will cause an exception and the app will break.
What is the new behavior?
The app won't crash after this key combination.
PR Checklist
Please check if your PR fulfills the following requirements: