New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing auth tests that were using expired tokens #650

Merged

stevengum merged 1 commit into master from jeffders/authtestfixes

Nov 20, 2018

Member

Jeffders commented Nov 20, 2018 •

edited by stevengum

Loading

Fixes: #533

Description

Verified that the removed tests were already covered by other tests.
Fixed checking for undefined so the correct error was thrown.
Added a missing case to the emulator path


          Fixing auth tests.

6823e7b

Jeffders requested a review from stevengum

November 20, 2018 17:14

coveralls commented Nov 20, 2018

Pull Request Test Coverage Report for Build 2190

1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.008%) to 82.154%

Totals
Change from base Build 2184:	0.008%
Covered Lines:	2630
Relevant Lines:	3083

💛 - Coveralls

stevengum approved these changes

View reviewed changes

Member

stevengum left a comment

stevengum merged commit 66dd368 into master

yochay mentioned this pull request

Author the 4.2 release notes for JS and C# Release microsoft/botframework-sdk#5197

Closed

cleemullins deleted the jeffders/authtestfixes branch

March 5, 2019 17:40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet