-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Builds are failing failing Auth Tests #533
Comments
temporarily disable AuthHeader tests to stop build breaks, #533
Update on this, for the What this means in a shallow sense is that the second test fails because the auth stack successfully validates the token though the channelId is incorrect (neither 'webchat' nor 'emulator'):
|
Unrelated issue found via #557: one of the ChannelValidator tests throws a TypeError instead of an Error with a custom message, indicating that the test may be finishing in an incorrect/unexpected fashion. |
This affects tests that do not use a valid MSA AppId and AppPassword, but instead use an old generated Auth Token. The problem is that whenever the keys get rotated out, the auth token becomes invalid and needs to be renewed.
Instead of continuing with this auth token route, JS should take should take a page out the .NET repo and get a new token whenever the tests are run in Travis.
The text was updated successfully, but these errors were encountered: