Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add userId parameter to signOutUser #837

Merged
merged 11 commits into from
Apr 13, 2019
Merged

Add userId parameter to signOutUser #837

merged 11 commits into from
Apr 13, 2019

Conversation

Aliandi
Copy link
Contributor

@Aliandi Aliandi commented Mar 26, 2019

Parity with C#

Description

It was found that the TypeScript method signOutUser() differed from the C# implementation of signOutUserAsync(). The TypeScript version expects less parameters, not letting the user pass a userId.

TypeScript
public async signOutUser(context: TurnContext, connectionName: string): Promise<void>

C#
public virtual async Task SignOutUserAsync(ITurnContext turnContext, string connectionName = null, string userId = null, CancellationToken cancellationToken = default(CancellationToken))

Specific Changes

  • add userId optional parameter to the method
  • add handling for when userId is null

@coveralls
Copy link

coveralls commented Mar 26, 2019

Pull Request Test Coverage Report for Build #2187

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 88.254%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder/src/botFrameworkAdapter.ts 0 2 0.0%
Totals Coverage Status
Change from base Build #2186: 0.006%
Covered Lines: 3234
Relevant Lines: 3521

💛 - Coveralls

@stevengum
Copy link
Member

@cleemullins, @BruceHaley any idea on this BotBuilder-JS-master-4.4-CI build? I just noticed this isn't in 4.3.x for JS but it is for C#....

@cleemullins cleemullins merged commit 3971e17 into master Apr 13, 2019
@cleemullins cleemullins deleted the issue/signOutUser branch April 13, 2019 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants