Add userId parameter to signOutUser

[Aliandi]

Parity with C#

Description

It was found that the TypeScript method signOutUser() differed from the C# implementation of signOutUserAsync(). The TypeScript version expects less parameters, not letting the user pass a userId.

TypeScript
public async signOutUser(context: TurnContext, connectionName: string): Promise<void>

C#
public virtual async Task SignOutUserAsync(ITurnContext turnContext, string connectionName = null, string userId = null, CancellationToken cancellationToken = default(CancellationToken))

Specific Changes

• add userId optional parameter to the method
• add handling for when userId is null

[coveralls]

Pull Request Test Coverage Report for Build #2052

• 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
• 2 unchanged lines in 1 file lost coverage.
• Overall coverage decreased (-0.1%) to 87.41%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
libraries/botbuilder/src/botFrameworkAdapter.ts	0	2	0.0%

Files with Coverage Reduction	New Missed Lines	%
libraries/botframework-config/src/botConfigurationBase.ts	2	85.59%

Totals
Change from base Build #2041:	-0.1%
Covered Lines:	3004
Relevant Lines:	3307

---

💛 - Coveralls

[cleemullins]

Is it practical to add a test around this?

[cleemullins]

Could you do this using a less weird syntax? This makes my head hurt.

[Aliandi]

Done!

[munozemilio]

Hi @Aliandi,

Fork merges are disabled that's why the build is failing. Chris has grant you write permissions to the repo.
Could you please push your changes in a new branch from this repo?

Thanks!

[Aliandi]

Replaced by #837