Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added timeout in luisRecognizer & qnaMaker for node #857

Merged
merged 4 commits into from
Apr 10, 2019

Conversation

Zerryth
Copy link
Contributor

@Zerryth Zerryth commented Apr 4, 2019

Part 1 of 2 PRs to fix microsoft/botframework-sdk#5196

Description

  • Added timeout option (in milliseconds) in LuisRecognizer and QnAMaker - Node
  • As in C# HttpClient, set timeout default to 100000 milliseconds

Specific Changes

LuisRecognizer

  • LuisPredictionOptions now extends ms-rest-js's PredictionResolveOptionalParams, whose parent (RequestOptionsBase interface) has optional timeout property

QnAMaker

  • QnAMakerOptions now has optional timeout
  • QnAMaker class constructor now sets timeout option in _options
  • queryQnaService() method passes timeout option into request() made to the QnA cognitive service

@coveralls
Copy link

Pull Request Test Coverage Report for Build #2168

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.05%) to 87.592%

Files with Coverage Reduction New Missed Lines %
libraries/botframework-config/src/botConfigurationBase.ts 2 85.59%
Totals Coverage Status
Change from base Build #2160: -0.05%
Covered Lines: 3192
Relevant Lines: 3501

💛 - Coveralls

@Zerryth
Copy link
Contributor Author

Zerryth commented Apr 10, 2019

@stevengum @daveta

Update:

@Zerryth Zerryth merged commit becfd72 into master Apr 10, 2019
@Zerryth Zerryth deleted the Zerryth/TimeoutNode branch April 10, 2019 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an optional timeout for LUIS and QnA calls
3 participants