Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an optional timeout for LUIS and QnA calls #5196

Closed
4 of 8 tasks
yochay opened this issue Dec 6, 2018 · 1 comment · Fixed by microsoft/botbuilder-js#857 or microsoft/botbuilder-dotnet#1635
Closed
4 of 8 tasks
Assignees

Comments

@yochay
Copy link
Contributor

yochay commented Dec 6, 2018

LUIS and QnA calls dont have a timeout param

When making a LUIS or QnA calls, there is no timeout, except the default one defined with HttpClient. One might want to limit time spent calling such services and 'abort' the call on timeout with an exception.

Proposed change

Add optional param for LUIS and QnA CTOR that includes timeout for each call, and throw an exception when it times out. This way customers can define a max timeout for calls and handle the error from their bot. If not, a call can spin for the default HTTP timeout which is 100 sec (I think).

Component Impact

Update LUIS and QnA libraries.

Note: LUIS C# RecognizeAsync already takes a cancelationToken. But QnA doesn't. Not sure how JS handles timeouts.

Customer Impact

Additive functionality.

Tracking Status

Dotnet SDK

  • PR
  • Merged

Javascript SDK

  • PR
  • Merged

Java SDK

  • PR
  • Merged

Python SDK

  • PR
  • Merged

[dcr]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment