Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: inherit font size and line height in hypertext styles #3320

Merged
merged 3 commits into from
Jun 16, 2020

Conversation

chrisdholt
Copy link
Member

@chrisdholt chrisdholt commented Jun 16, 2020

Description

The intent of the hypertext styling on fast-anchor is that it be used inline with other text. This change updates the styles to better align with that intent by inheriting line height and font-size. If a user needs a similar solution for a non-inline scenario they can use the lightweight appearance of fast-anchor where the font size is set to align with other button appearances.

Motivation & context

Issue type checklist

  • Chore: A change that does not impact distributed packages.
  • Bug fix: A change that fixes an issue, link to the issue above.
  • New feature: A change that adds functionality.

Is this a breaking change?

  • This change causes current functionality to break.

Adding or modifying component(s) in @microsoft/fast-components checklist

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Copy link
Contributor

@EisenbergEffect EisenbergEffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes total sense.

@EisenbergEffect EisenbergEffect mentioned this pull request Jun 16, 2020
35 tasks
@chrisdholt chrisdholt merged commit 98348cb into master Jun 16, 2020
@chrisdholt chrisdholt deleted the users/chhol/inherit-font-properties-on-hypertext branch June 16, 2020 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants