Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launch FAST #3307

Closed
31 of 35 tasks
EisenbergEffect opened this issue Jun 15, 2020 · 8 comments
Closed
31 of 35 tasks

Launch FAST #3307

EisenbergEffect opened this issue Jun 15, 2020 · 8 comments
Labels
feature A new feature

Comments

@EisenbergEffect
Copy link
Contributor

EisenbergEffect commented Jun 15, 2020

An ordered checklist of what we need to do to launch FAST:

@triage-new-issues triage-new-issues bot added the status:triage New Issue - needs triage label Jun 15, 2020
@EisenbergEffect
Copy link
Contributor Author

EisenbergEffect commented Jun 15, 2020

Ping @awentzel. The homepage/docs integration PR is up. So, I believe you can proceed with the pipeline work.

@EisenbergEffect EisenbergEffect added feature A new feature and removed status:triage New Issue - needs triage labels Jun 15, 2020
@chrisdholt
Copy link
Member

@EisenbergEffect I was rolling through this and noticed the following:

URLs pointing to external resources (non fast.design pages) should open in external window/tab via "_blank" attribute improved SEO and keeping people on our site.

I think we should scratch this in favor of providing the user the opportunity to open whatever external link they want either in the browser or outside of it. I have concerns about usurping their choice in favor of us prioritizing keeping our content open in a window. There's a ton of quick ways to navigate around the web and many users have preference on when and how they manage their tabs/windows. In certain cases this makes sense, such as when you have links as part of active forms or sites where editing is taking place. In those cases navigation could zero out changes being made and opening links in new tabs/windows makes sense. Outside of that though, I don't see a reason to shift from the default behavior of allowing users to open tabs however they prefer.

@EisenbergEffect
Copy link
Contributor Author

I didn't add that particular line-item. So, no disagreement from me. Maybe @awentzel had some thoughts?
In terms of the Markdown, it's just a normal Markdown link. I didn't alter any behavior from the default.

@chrisdholt
Copy link
Member

I didn't add that particular line-item. So, no disagreement from me. Maybe @awentzel had some thoughts?
In terms of the Markdown, it's just a normal Markdown link. I didn't alter any behavior from the default.

For now I've removed the following:

  • URLs pointing to external resources (non fast.design pages) should open in external window/tab via "_blank" attribute improved SEO and keeping people on our site.

I'm open to discussing the above in an issue if people are passionate. For now, I don't think there is consensus on that functionality/behavior. I also don't think it's required for launch.

@chrisdholt chrisdholt pinned this issue Jun 23, 2020
@EisenbergEffect
Copy link
Contributor Author

@awentzel There's an item above labeled "Implement and merge review feedback from @awentzel from feature branch into master" Was that tracking your early feedback on the docs (already incorporated) or is that something else we still need to do?

@EisenbergEffect
Copy link
Contributor Author

Ping @awentzel for feedback on the above.

@EisenbergEffect
Copy link
Contributor Author

@chrisdholt Can you add any work items to this list that are still not done so we have a sense of what's left to get launched?

@chrisdholt
Copy link
Member

@eisenbereffect Once we fill out the above, we are good to go. Site is ready for initial publish (yay continuous integration 😄). I believe the component explorer is ready. We can publish as needed. I think we have what we need to close this out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature
Projects
None yet
Development

No branches or pull requests

2 participants