-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Launch FAST #3307
Comments
Ping @awentzel. The homepage/docs integration PR is up. So, I believe you can proceed with the pipeline work. |
@EisenbergEffect I was rolling through this and noticed the following:
I think we should scratch this in favor of providing the user the opportunity to open whatever external link they want either in the browser or outside of it. I have concerns about usurping their choice in favor of us prioritizing keeping our content open in a window. There's a ton of quick ways to navigate around the web and many users have preference on when and how they manage their tabs/windows. In certain cases this makes sense, such as when you have links as part of active forms or sites where editing is taking place. In those cases navigation could zero out changes being made and opening links in new tabs/windows makes sense. Outside of that though, I don't see a reason to shift from the default behavior of allowing users to open tabs however they prefer. |
I didn't add that particular line-item. So, no disagreement from me. Maybe @awentzel had some thoughts? |
For now I've removed the following:
I'm open to discussing the above in an issue if people are passionate. For now, I don't think there is consensus on that functionality/behavior. I also don't think it's required for launch. |
Ping @awentzel for feedback on the above. |
@chrisdholt Can you add any work items to this list that are still not done so we have a sense of what's left to get launched? |
@eisenbereffect Once we fill out the above, we are good to go. Site is ready for initial publish (yay continuous integration 😄). I believe the component explorer is ready. We can publish as needed. I think we have what we need to close this out! |
An ordered checklist of what we need to do to launch FAST:
The text was updated successfully, but these errors were encountered: