Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wait to initialize homepage components with dom dependencies #3367

Merged
merged 1 commit into from
Jun 24, 2020

Conversation

radium-v
Copy link
Collaborator

Description

This commit resolves a console error on the homepage and addresses DOM ordering and stacking for fixed elements.

Motivation & context

These issues were introduced with #3358 since the DOM is now loaded after the bundle.

Issue type checklist

  • Chore: A change that does not impact distributed packages.
  • Bug fix: A change that fixes an issue, link to the issue above.
  • New feature: A change that adds functionality.

Is this a breaking change?

  • This change causes current functionality to break.

Adding or modifying component(s) in @microsoft/fast-components checklist

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

- set chunks: all in webpack prod config
Copy link
Contributor

@EisenbergEffect EisenbergEffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. My guess is that the bug was due to the streaming nature of HTML. Does that sound right?

@radium-v radium-v self-assigned this Jun 24, 2020
@EisenbergEffect EisenbergEffect mentioned this pull request Jun 24, 2020
35 tasks
@radium-v
Copy link
Collaborator Author

@EisenbergEffect The <background-design> needs to watch the #hero with an IntersectionObserver - same with the <site-side-navigation> component, which needs to know how many <section>s exist to generate correctly. I'm thinking now that a better solution may be to move these observers outside of the components themselves and into a more general-purpose page script.

@radium-v radium-v merged commit 9a173de into master Jun 24, 2020
@radium-v radium-v deleted the users/jokreitl/site-loading branch June 24, 2020 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants