chore: update to dim bg when page scrolls beyond hero #3333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radium-v
requested review from
chrisdholt,
janechu and
nicholasrice
as code owners
chrisdholt
reviewed
Jun 17, 2020
Comment on lines
92
to
104
| setupFadeObserver() { | ||
| const observer = new IntersectionObserver( | ||
| entries => { | ||
| entries.forEach(entry => (this.faded = !entry.isIntersecting)); | ||
| }, | ||
| { threshold: [0.5] } | ||
| ); | ||
|
|
||
| const heroSection: HTMLElement = document.getElementById("hero") as HTMLElement; | ||
|
|
||
| observer.observe(heroSection); |
chrisdholt
reviewed
Jun 17, 2020
| { threshold: [0.5] } | ||
| ); | ||
|
|
||
| const heroSection: HTMLElement = document.getElementById("hero") as HTMLElement; |
There was a problem hiding this comment.
I don't have a good proposal, but curious if there are any issue with referencing this (assuming it's in another elements shadow DOM?)...
There was a problem hiding this comment.
It's actually an element in the actual DOM. Since the background itself doesn't scroll, we need to observe something that does.
There was a problem hiding this comment.
party, if it's in the light dom we are good 👍
chrisdholt
approved these changes
Jun 17, 2020
radium-v
force-pushed
the
users/jokreitl/site-bg-dim
branch
from
3c1bb9e
to
16bcb7f
Compare
EisenbergEffect
approved these changes
Jun 17, 2020
| const observer = new IntersectionObserver( | ||
| entries => { | ||
| entries.forEach(entry => { | ||
| this.faded = entry.intersectionRatio < 0.5; |
awentzel
changed the title
radium-v
force-pushed
the
users/jokreitl/site-bg-dim
branch
from
16bcb7f
to
46ff18c
Compare
SamanthaAO
approved these changes
Jun 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change dims the background when the page is scrolled past the hero.
Motivation & context
To aid visual accessibility, the background needs to provide better contrast when behind the page content.
Issue type checklist
Is this a breaking change?
Adding or modifying component(s) in
@microsoft/fast-componentschecklistProcess & policy checklist