Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion: Query clipboard permissions when opening an existing server instead of always prompting #10191

Closed
Tracked by #10435
Tyriar opened this issue May 31, 2022 · 3 comments · Fixed by #10602
Closed
Tracked by #10435

Suggestion: Query clipboard permissions when opening an existing server instead of always prompting #10191

Tyriar opened this issue May 31, 2022 · 3 comments · Fixed by #10602
Labels
bug Issue identified by VS Code Team member as probable bug papercut 🩸 Something affecting the productivity of the team verified Verification succeeded
Milestone
July 2022

Comments

@Tyriar
Copy link
Member

Tyriar commented May 31, 2022 •
edited
Loading

Testing #10170

I find the setting up Jupyter experience kind of complicated. Have you considered doing a soft permissions query instead of a hard text read when connecting to avoid this prompt? Additionally, it would be better from a user's perspective imo to ask for the clipboard on ctrl/cmd+v, not when clicking some button.

Screen Shot 2022-05-31 at 10 12 11 am

navigator.permissions.query({ name: 'clipboard-read' }).then(console.log)
@Tyriar Tyriar added the bug Issue identified by VS Code Team member as probable bug label May 31, 2022
@github-actions github-actions bot added the triage-needed Issue needs to be triaged label May 31, 2022
@Tyriar Tyriar mentioned this issue May 31, 2022
Closed
@greazer greazer added vscode-web papercut 🩸 Something affecting the productivity of the team and removed triage-needed Issue needs to be triaged labels Jun 2, 2022
@greazer greazer added this to the June 2022 milestone Jun 2, 2022
@greazer greazer removed this from the June 2022 milestone Jun 2, 2022
@greazer
Copy link
Member

greazer commented Jun 2, 2022

nb-golden due to #10192

@greazer greazer added this to the June 2022 milestone Jun 2, 2022
@kieferrm kieferrm mentioned this issue Jun 11, 2022
Closed
19 tasks
@rchiodo rchiodo mentioned this issue Jun 13, 2022
Closed
2 tasks
@rchiodo rchiodo mentioned this issue Jun 28, 2022
Merged
9 tasks
@rchiodo rchiodo modified the milestones: June 2022, July 2022 Jun 30, 2022
@connor4312 connor4312 added the verified Verification succeeded label Jul 27, 2022
@connor4312
Copy link
Member

This didn't work unless I added the setting referenced in #10363 (comment), I assume that's implied?

image

@rchiodo
Copy link
Contributor

rchiodo commented Jul 27, 2022

Yeah sorry. I closed all of these bugs before we added the setting.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Issue identified by VS Code Team member as probable bug papercut 🩸 Something affecting the productivity of the team verified Verification succeeded
Projects
None yet
Milestone
July 2022
Development

Successfully merging a pull request may close this issue.

Support remote commands in the kernel picker microsoft/vscode-jupyter
4 participants
@Tyriar @connor4312 @greazer @rchiodo