Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Variable Viewer in the web #10170

Closed
2 tasks done
sadasant opened this issue May 27, 2022 · 14 comments
Closed
2 tasks done

Test Variable Viewer in the web #10170

sadasant opened this issue May 27, 2022 · 14 comments
Labels
testplan-item triage-needed Issue needs to be triaged
Milestone

Comments

@sadasant
Copy link
Contributor

sadasant commented May 27, 2022

Refs: #9664

Complexity: 4

Create Issue


Requirements

Set up

  1. Go to a command prompt where you've installed jupyter into a python environment
  2. Switch to a folder you're using for testing
  3. Run jupyter with the following command jupyter notebook --no-browser --NotebookApp.allow_origin=*

Test Steps

  1. Open insiders.vscode.dev and create a new python file
  2. Add variables in the python file (Try adding some, and then in another run try adding many different variables).
  3. Connet to the jupyter server:
    1. Run the 'Jupyter: Specify jupyter server for connections' command, or use the link from the IW's info message
    2. Pick 'Existing'
    3. Paste the URL from the jupyter notebook server you started in step 3 of the setup
  4. Run the command Jupyter: Focus on Variables View.
  5. Run the file with Juptyer: Run Current File in Interactive Window.
  6. See that the variables in the Variable View matched the expectations.

Try again with a .ipynb file:

  1. Open insiders.vscode.dev and create a new .ipynb file.
  2. Add variables in the python file (Try adding some, and then in another run try adding many different variables).
  3. Connet to the jupyter server:
    1. Run the 'Jupyter: Specify jupyter server for connections' command, or use the link from the IW's info message
    2. Pick 'Existing'
    3. Paste the URL from the jupyter notebook server you started in step 3 of the setup
  4. Run the command Jupyter: Focus on Variables View.
  5. Run the cells on your file.
  6. See that the variables in the Variable View matched the expectations.
@sadasant sadasant added bug Issue identified by VS Code Team member as probable bug testplan-item triage-needed Issue needs to be triaged labels May 27, 2022
@sadasant sadasant removed the bug Issue identified by VS Code Team member as probable bug label May 27, 2022
@ghost ghost assigned Tyriar and weinand May 31, 2022
@weinand
Copy link

weinand commented May 31, 2022

@sadasant I cannot find the "Jupyter: Open Variable View" command. All I have is a "Jupyter: Focus on Variables View".

I'm using this version of the Jupyter extension:

CleanShot 2022-05-31 at 17 02 42@2x

@sadasant
Copy link
Contributor Author

@weinand ”Jupyter: Focus on Variables View” should also open it — let’s try with that one!

Now, “ Jupyter: Open Variable View” should appear. We’ll investigate!

@weinand
Copy link

weinand commented May 31, 2022

@sadasant ”Jupyter: Focus on Variables View” opens the "Jupyter: Variables" view but no contents is shown and the blue progress spinner runs forever:

CleanShot 2022-05-31 at 18 15 05

BTW, in the desktop version of VS Code I'm neither seeing a ”Jupyter: Focus on Variables View” command, nor a “Jupyter: Open Variable View” ...

@sadasant
Copy link
Contributor Author

@weinand You are correct, Jupyter: Open Variable View does not exist, it's Jupyter: Focus on Variables View. I'll update the description.

The steps I provided might not be the best ones. Do you mind running these steps instead?

  1. Make sure you're in the browser version of VSCode.
  2. Create a new Python file.
  • The one in the screenshot you shared looks ok to me.
  1. Run Jupyter: Specify jupyter server for connections.
  • Make sure to paste the right URL.
  1. Run Juptyer: Run Current File in Interactive Window.
  2. After it runs, run Jupyter: Focus on Variables View.
  • The variables should appear in a panel at the bottom.

Screen Shot 2022-05-31 at 2 04 29 PM

Doest that work? Feedback always appreciated 🙏

@weinand
Copy link

weinand commented May 31, 2022

@sadasant the variables view doesn't work for me.
Jupyter: Run Current File in Interactive Window works fine and Jupyter: Focus on Variables View opens the "Jupyter: Variables" view but no contents is shown and the blue progress spinner runs forever:

CleanShot 2022-05-31 at 22 29 44

I'm on macOS 12.4 and I'm using python 3.10.0 and pip 22.1.2 via pyenv.

@weinand weinand added this to the May 2022 milestone May 31, 2022
@sadasant
Copy link
Contributor Author

Thank you, @weinand ! I'm investigating.

@Tyriar
Copy link
Member

Tyriar commented May 31, 2022

@sadasant I also see this, don't think I can test continue testing this, here's the console if that's helpful:

Screen Shot 2022-05-31 at 3 44 55 pm

@sadasant
Copy link
Contributor Author

@weinand turns out we haven't published the Variable Viewer! Our build failed on Friday. I'll provide an update soon.

@sadasant
Copy link
Contributor Author

@Tyriar Thank you! Those logs are expected at the moment.

However, it turns out we haven't published the Variable Viewer! Our build failed on Friday.

I'll provide an update soon.

@sadasant
Copy link
Contributor Author

@weinand , @Tyriar we have just published this feature with version 2022.5.1001532360. I have also confirmed that it works! (At least or me) Please, try again 🙇‍♂️

@weinand
Copy link

weinand commented Jun 1, 2022

@sadasant yes, with the new version things look much better...

This was referenced Jun 1, 2022
@Tyriar Tyriar removed their assignment Jun 1, 2022
@Tyriar Tyriar closed this as completed Jun 1, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
testplan-item triage-needed Issue needs to be triaged
Projects
None yet
Development

No branches or pull requests

5 participants
@sadasant @weinand @amunger @Tyriar and others