Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variable viewer: Show variable in data viewer does nothing #10229

Closed
Tyriar opened this issue Jun 1, 2022 · 4 comments · Fixed by #10305
Closed

Variable viewer: Show variable in data viewer does nothing #10229

Tyriar opened this issue Jun 1, 2022 · 4 comments · Fixed by #10305
Assignees
@sadasant
Labels
variable-explorer

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 1, 2022

Testing #10170

Clicking this doesn't do anything for me

Screen Shot 2022-06-01 at 7 22 16 am
@github-actions github-actions bot added the triage-needed Issue needs to be triaged label Jun 1, 2022
@Tyriar Tyriar mentioned this issue Jun 1, 2022
Closed
@rchiodo
Copy link
Contributor

rchiodo commented Jun 1, 2022

We should disable this button in the web version of the extension until it's supported.

@sadasant sadasant removed the triage-needed Issue needs to be triaged label Jun 1, 2022
@sadasant
Copy link
Contributor

sadasant commented Jun 1, 2022

I'll work on this today! Thank you 👍

@sadasant sadasant mentioned this issue Jun 3, 2022
Merged
@Tyriar
Copy link
Member Author

Tyriar commented Jun 13, 2022

@sadasant should a milestone be attached to this and the PR?

@sadasant
Copy link
Contributor

@Tyriar we decided to disable this button last week. It should be disabled in the released build as well as in the last available build. What happened is that I wasn't aware how this button related to a feature I couldn't get to during last month, which is: #9665 -- 9665 is one of my first priorities this week. That is to say, the underlying issue is indeed scheduled to be accounted for during a milestone, that is June 2022.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sadasant sadasant

Labels
variable-explorer
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Hiding the data viewer on the variable viewer if web sadasant/vscode-jupyter
4 participants
@sadasant @rebornix @Tyriar @rchiodo