Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hiding the data viewer on the variable viewer if web #10305

Merged
merged 7 commits into from
Jun 3, 2022

Conversation

sadasant
Copy link
Contributor

@sadasant sadasant commented Jun 3, 2022

And hiding the plot viewer buttons on the web as well.

This PR:

Fixes #10229
Fixes #10280

@sadasant sadasant requested a review from rchiodo June 3, 2022 20:37
@sadasant sadasant requested a review from a team as a code owner June 3, 2022 20:37
@sadasant sadasant self-assigned this Jun 3, 2022
@sadasant sadasant merged commit f32d261 into microsoft:main Jun 3, 2022
@sadasant sadasant deleted the show-variable-data-viewer branch June 3, 2022 21:21
sadasant added a commit to sadasant/vscode-jupyter that referenced this pull request Jun 3, 2022
* wip

* wip

* almost there

* both fixes in the same commit, I need to clean this up

* Not using IsWebExtension

* no more console logs

* no more TODO comment
sadasant added a commit that referenced this pull request Jun 3, 2022
* Hiding the data viewer on the variable viewer if web (#10305)

* wip

* wip

* almost there

* both fixes in the same commit, I need to clean this up

* Not using IsWebExtension

* no more console logs

* no more TODO comment

* changelog entry

* comment about the DataFrame viewer and the Plot viewer
sadasant added a commit to sadasant/vscode-jupyter that referenced this pull request Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants