Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer an output channel over console.log #10202

Closed
Tyriar opened this issue May 31, 2022 · 6 comments · Fixed by #10341
Closed

Prefer an output channel over console.log #10202

Tyriar opened this issue May 31, 2022 · 6 comments · Fixed by #10341
Assignees
Labels
debt Code quality issues

Comments

@Tyriar
Copy link
Member

Tyriar commented May 31, 2022

Testing #10170

I see a bunch of console.logs when opening a Python notebook, these should go to the Jupyter output channel instead to try keep the main devtools console clean.

Screen Shot 2022-05-31 at 3 49 59 pm

@github-actions github-actions bot added the triage-needed Issue needs to be triaged label May 31, 2022
@rchiodo
Copy link
Contributor

rchiodo commented May 31, 2022

Those are actually from an npm module we consume. I suppose we could have it send a message instead.

@rchiodo
Copy link
Contributor

rchiodo commented May 31, 2022

Or maybe just remove those and only log errors.

@Tyriar
Copy link
Member Author

Tyriar commented May 31, 2022

That makes things trickier if you don't own the code, this is a pretty minor issue that mainly helps vscode devs/extension authors, feel free to close off if it would involve upstream changes that probably won't happen.

@rchiodo
Copy link
Contributor

rchiodo commented May 31, 2022

Oh we actually own the npm module. It's this one:
https://github.com/microsoft/vscode-jupyter-ipywidgets.git

@Tyriar
Copy link
Member Author

Tyriar commented May 31, 2022

@rchiodo is that for all 3? There's the SW ones, ipywidgets and the requirejs one (in a file that has console.warn("Registering custom require.js for Jupyter Kernel"))

@rchiodo
Copy link
Contributor

rchiodo commented May 31, 2022

SW wouldn't be us AFAIK.

The require.js one is likely another renderer side script we generate.

@rchiodo rchiodo added the debt Code quality issues label May 31, 2022
@greazer greazer added engineering and removed triage-needed Issue needs to be triaged labels Jun 2, 2022
@rchiodo rchiodo self-assigned this Jun 3, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants