-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefer an output channel over console.log #10202
Comments
Those are actually from an npm module we consume. I suppose we could have it send a message instead. |
Or maybe just remove those and only log errors. |
That makes things trickier if you don't own the code, this is a pretty minor issue that mainly helps vscode devs/extension authors, feel free to close off if it would involve upstream changes that probably won't happen. |
Oh we actually own the npm module. It's this one: |
@rchiodo is that for all 3? There's the SW ones, ipywidgets and the requirejs one (in a file that has |
SW wouldn't be us AFAIK. The require.js one is likely another renderer side script we generate. |
Testing #10170
I see a bunch of console.logs when opening a Python notebook, these should go to the Jupyter output channel instead to try keep the main devtools console clean.
The text was updated successfully, but these errors were encountered: