Remove console log usage #10341
Merged
Remove console log usage #10341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchiodo
commented
Jun 6, 2022
| @@ -106,7 +106,7 @@ export class IPyWidgetMessageDispatcher implements IIPyWidgetMessageDispatcher { | |||
| public receiveMessage(message: IPyWidgetMessage): void { | |||
| switch (message.message) { | |||
| case IPyWidgetMessages.IPyWidgets_logMessage: | |||
| traceInfoIfCI(`Widget Message: ${message.payload}`); | |||
| traceInfo(`Widget Message: ${message.payload}`); | |||
There was a problem hiding this comment.
Made this traceInfo because after these two changes, this is really only stuff that we actually want to show to the user (or us when request logs).
rchiodo
commented
Jun 6, 2022
| @@ -393,9 +390,6 @@ class ProxyKernel implements IMessageHandler, Kernel.IKernelConnection { | |||
| } | |||
| private messageHookInterceptor(msg: KernelMessage.IIOPubMessage): boolean | PromiseLike<boolean> { | |||
| try { | |||
| logMessageOnlyOnCI( | |||
There was a problem hiding this comment.
Figured if we needed these later, we can add a new IPYWidgets_LogMessageIfCI message. Then on the other side it would only log these if running on CI.
Codecov Report
@@ Coverage Diff @@
## main #10341 +/- ##
=====================================
- Coverage 64% 64% -1%
=====================================
Files 212 212
Lines 9557 9557
Branches 1527 1527
=====================================
- Hits 6148 6145 -3
- Misses 2932 2934 +2
- Partials 477 478 +1
|
amunger
approved these changes
Jun 6, 2022
DonJayamanne
approved these changes
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10202
Related to the PR I have in the ipywidget npm module, this removes uses of console.log in our renderers. Mostly it was widget stuff.
microsoft/vscode-jupyter-ipywidgets#3