-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Variable viewer: Can you retain the webview context when hidden? #10240
Comments
I believe we refresh on purpose. Storing context only works if the user hasn't executed anything between hiding and showing again. |
You could keep the context and trigger a refresh when the webview is shown instead of recreating it completely? |
Not sure what the difference would be? Less flashing? |
Yeah, it should load about as fast as the built-in panels then and feel more smooth/integrated. |
I like the idea of less flashing! We'll circle back after triage. |
For refreshing, I also expect it does diffing and update incrementally instead of refreshing the whole page. |
The react data grid we use should already be doing this. There is only flashing when we hide the window. |
This was done on purpose to prevent execution from happening while the window is hidden. vscode-jupyter/src/webviews/extension-side/variablesView/variableViewActivationService.ts Line 20 in e6f523d
We could try detecting if the view is visible or not in the refresh though, and then set it to a pending refresh for when it becomes visible again. |
Whoops wrong issue closed. |
Testing #10170
I know this is an option for custom editors, if it's available to webview panels that would save reloading the whole webview when re-focused (at the cost of keeping the context in memory):
The text was updated successfully, but these errors were encountered: