Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrolling cells off screen prevents rendering widgets #10485

Closed
rchiodo opened this issue Jun 17, 2022 · 12 comments · Fixed by #10491
Closed

Scrolling cells off screen prevents rendering widgets #10485

rchiodo opened this issue Jun 17, 2022 · 12 comments · Fixed by #10491
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@rchiodo
Copy link
Contributor

rchiodo commented Jun 17, 2022

Have a notebook with enough cells that cells scroll off screen.

Render something like bqplot graphs off screen.

Scroll up.

Expected:

  • Plots show up
    Actual:
  • There's no output.
@rchiodo rchiodo added bug Issue identified by VS Code Team member as probable bug notebook-regression labels Jun 17, 2022
@rchiodo rchiodo added this to the June 2022 milestone Jun 17, 2022
@github-actions github-actions bot added the triage-needed Issue needs to be triaged label Jun 17, 2022
@rchiodo
Copy link
Contributor Author

rchiodo commented Jun 17, 2022

With this prerelease version:

Name: Jupyter
Id: ms-toolsai.jupyter
Description: Jupyter notebook support, interactive programming and computing that supports Intellisense, debugging and more.
Version: 2022.6.1001691033
Publisher: Microsoft
VS Marketplace Link: https://marketplace.visualstudio.com/items?itemName=ms-toolsai.jupyter

The expected results happen.

@rchiodo
Copy link
Contributor Author

rchiodo commented Jun 17, 2022

This notebook will repro the problem:
bqplot_crash.zip

It does crash the extension host, but that's a separate issue:
#10386

@rchiodo
Copy link
Contributor Author

rchiodo commented Jun 17, 2022

After about 60 seconds a bunch of errors start popping up

image

@DonJayamanne
Copy link
Contributor

@rchiodo please could you:

  • Provide the first error from the logs
  • Look at the network tab and find the first error for failures to download static files (looks like some widget wasn't downloaded)
  • Also can you provide the output from your Jupyter console (need to check if its using CDN or not)

@rchiodo
Copy link
Contributor Author

rchiodo commented Jun 17, 2022

Here's a log after it didn't render offscreen:
jupyterlog.txt

@rchiodo
Copy link
Contributor Author

rchiodo commented Jun 17, 2022

Seems like undoing 94de3cd fixes the problem

@DonJayamanne
Copy link
Contributor

I'd just undo the changes to the `src/webviews/webview-side/ipywidgets/kernel/index.ts`` file

@DonJayamanne
Copy link
Contributor

removing the regression label as it hasn't been shipped yet.

@DonJayamanne DonJayamanne removed their assignment Jun 17, 2022
@rchiodo rchiodo self-assigned this Jun 17, 2022
@rchiodo rchiodo removed the triage-needed Issue needs to be triaged label Jun 30, 2022
@rchiodo
Copy link
Contributor Author

rchiodo commented Jun 30, 2022

Verification steps:

  1. Install bqplot, numpy, and pandas into a python environment
  2. Open this notebook
    bqplot_test.zip
  3. Select the environment you created as the kernel
  4. Scroll to the bottom and run all the cells above (there's a button on the notebook cell for running cells above)
  5. Scroll back up and there should be plots showing up.

@rebornix
Copy link
Member

rebornix commented Jul 1, 2022

I'm not able to verify on my machine due to #10386

@rchiodo
Copy link
Contributor Author

rchiodo commented Jul 1, 2022

There's a workaround for #10386:

"jupyter.disableZMQSupport": true

@rebornix rebornix added the verified Verification succeeded label Jul 1, 2022
@rebornix
Copy link
Member

rebornix commented Jul 1, 2022

That works great!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
3 participants