Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce vsix size by removing redundant files, source map and typings #4551

Closed
rebornix opened this issue Jan 28, 2021 · 2 comments
Closed

Reduce vsix size by removing redundant files, source map and typings #4551

rebornix opened this issue Jan 28, 2021 · 2 comments
Labels
debt Code quality issues perf Performance issues

Comments

@rebornix
Copy link
Member

Environment data

  • VS Code version: 1.52-Insiders
  • Jupyter Extension version (available under the Extensions sidebar): v2021.1.499599561-dev
  • OS (Windows | Mac | Linux distro) and version: macOS
  • Python and/or Anaconda version: 2.7.5
  • Type of virtual environment used (N/A | venv | virtualenv | conda | ...): N/A
  • Jupyter server running: Local | Remote | N/A

The vsix is currently 25MB, which is pretty large compared to other extensions or VS Code itself (~70MB on Windows). After taking a look at what are bundled into the vsix, I found that

  • Three copies of vendor renderers (datasource.bundle, geojson, vega, nteract, etc). Each copy is around 7.5MB
  • Multiple copies of require.js (note that VS Code renderer ships with AMD loader)
  • Tens of MB source map files, which are not necessary for release

By removing them, the vsix can go down to 16MB (64%), though it's still large, but it's much better than before.

@rebornix rebornix added the bug Issue identified by VS Code Team member as probable bug label Jan 28, 2021
@greazer
Copy link
Member

greazer commented Aug 8, 2021

Basically a dupe of #5870.

@greazer greazer added perf Performance issues debt Code quality issues engineering labels Aug 8, 2021
@greazer greazer removed the bug Issue identified by VS Code Team member as probable bug label Oct 10, 2021
@rchiodo
Copy link
Contributor

rchiodo commented Oct 18, 2021

This should be completed. Current size is 12MB

@rchiodo rchiodo closed this as completed Oct 18, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues perf Performance issues
Projects
None yet
Development

No branches or pull requests

4 participants