Eliminate unnecessary dupe files and map files in VSIX #4665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchiodo
commented
Feb 5, 2021
| @@ -27,7 +27,6 @@ import { PostOffice } from '../../react-common/postOffice'; | |||
| import { combineReducers, createQueueableActionMiddleware, QueuableAction } from '../../react-common/reduxUtils'; | |||
| import { computeEditorOptions, getDefaultSettings } from '../../react-common/settingsReactSide'; | |||
| import { createEditableCellVM, generateTestState } from '../mainState'; | |||
| import { forceLoad } from '../transforms'; | |||
There was a problem hiding this comment.
THis one import was pulling in 20MB of stuff into the dataviewer/plotviewer/variableviewer
There was a problem hiding this comment.
20MB unzipped that is.
DavidKutu
approved these changes
Feb 5, 2021
joyceerhl
approved these changes
Feb 5, 2021
DonJayamanne
approved these changes
Feb 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #4551
Map files aren't needed in the vsix.
Additionally the 'forceLoad' function for test code was forcing the transforms.tsx file to get pulled in which brings in a whole host of other imports. This is only necessary for the webview editors.