-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jupyter specific commands incorrectly show up for all notebook editors #5559
Comments
If these commands are Juypter specific, I believe you need to use a more specific context key here: https://github.com/microsoft/vscode-jupyter/blob/main/package.json#L1178 It's also confusing that these commands are under the generic /cc @rebornix |
@DavidKutu i think this should be an easy fix.. |
Last we discussed this. We decided to change Jupyter to notebook. Either it's all consistently Jupyter or notebook, the later is the oblivious choice. For users of ipynb (Jupyter) they wouldn't care whether it's a command contributed by vscode or an extension, they just called about notebooks. |
Validated. The expand/collapse all notebook cells commands are now hidden when a GitHub issues notebook is active and visible when a Jupyter notebook is active. |
Repro
Notebook: collapse all notebook cells
bug
The text was updated successfully, but these errors were encountered: