Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jupyter specific commands incorrectly show up for all notebook editors #5559

Closed
mjbvz opened this issue Apr 20, 2021 · 4 comments
Closed

Jupyter specific commands incorrectly show up for all notebook editors #5559

mjbvz opened this issue Apr 20, 2021 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Apr 20, 2021

Repro

  1. With Jupyter installed
  2. Open a GitHub issues notebook
  3. In the command platte, run Notebook: collapse all notebook cells

bug

Screen Shot 2021-04-19 at 5 46 33 PM

@mjbvz mjbvz added the bug Issue identified by VS Code Team member as probable bug label Apr 20, 2021
@mjbvz
Copy link
Contributor Author

mjbvz commented Apr 20, 2021

If these commands are Juypter specific, I believe you need to use a more specific context key here: https://github.com/microsoft/vscode-jupyter/blob/main/package.json#L1178

It's also confusing that these commands are under the generic Notebook command group. It made me think they were coming from VS Code at first

/cc @rebornix

@DonJayamanne
Copy link
Contributor

@DavidKutu i think this should be an easy fix..

@DonJayamanne
Copy link
Contributor

confusing that these commands are under the generic Notebook command group. It made me think they were coming from VS Code at first

Last we discussed this. We decided to change Jupyter to notebook.
I think it should start as notebook.
Most of the Jupyter users will be using notebook command to create cells, switch kernel, etc, and those are prefixed Notebook having others prefixed Jupyter is confusing.

Either it's all consistently Jupyter or notebook, the later is the oblivious choice.
I think hiding the command for other notebooks will address the problem you had.

For users of ipynb (Jupyter) they wouldn't care whether it's a command contributed by vscode or an extension, they just called about notebooks.

@joyceerhl
Copy link
Contributor

joyceerhl commented Apr 23, 2021

Validated. The expand/collapse all notebook cells commands are now hidden when a GitHub issues notebook is active and visible when a Jupyter notebook is active.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

4 participants