-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide jupyter commands from other types of notebooks #5574
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need a when clause instead
I believe we use 'Notebook' on purpose. Isn't this going to make all of those commands prefixed with 'Jupyter' instead? That seems more confusing to me. |
@rchiodo I could leave only the changes to the when clause, that's enough to fix the issue. |
@rchiodo I believe Matt said in #5559 that our using 'Notebook' is confusing, because the category also indicates where the command is coming from. E.g. 'Notebook' means 'VS Code-contributed' while 'Jupyter' means 'Jupyter extension-contributed'. Since this command is contributed by the Jupyter extension I think it makes sense to prefix it with 'Jupyter'. I'm also wondering if Peng/Matt have further thoughts on this. |
Codecov Report
@@ Coverage Diff @@
## main #5574 +/- ##
=====================================
- Coverage 72% 72% -1%
=====================================
Files 402 402
Lines 26641 26641
Branches 3887 3887
=====================================
- Hits 19444 19406 -38
- Misses 5589 5619 +30
- Partials 1608 1616 +8
|
@joyceerhl I don't think we should change the command group to Jupyter. It's something we discussed as a team (I think we even have an issue for this), I believe it came out of a QP study |
@joyceerhl that's a good topic to bring up in our next sync meeting. I'd vote to have everything we contribute in the |
For #5559
package-lock.json
has been regenerated by runningnpm install
(if dependencies have changed).