Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native Notebooks - Reduce languages displayed based on what kernel supports #5580

Closed
claudiaregio opened this issue Apr 21, 2021 · 6 comments

Comments

@claudiaregio
Copy link
Contributor

claudiaregio commented Apr 21, 2021

VS Code has finally enabled kernel supported language 🎉
microsoft/vscode#116314

Let's reduce the number of languages that are displayed to a user once they click on the language picker based on what the kernel supports.

Issue will be updated after meeting with Don to create shortlist.
This will also support the .NET team's requested experience.

@DonJayamanne
Copy link
Contributor

This will also support the .NET team's requested experience.

No this won't.
.net team will have to make their own changes in their kernel. Ie they own the kernel, hence the languages as well.

@DonJayamanne DonJayamanne self-assigned this Apr 21, 2021
@claudiaregio
Copy link
Contributor Author

Sorry, I meant the API would support it. The .NET team would do the work to expose those languages which in turn would be found by that API. Is that understanding correct?

@greazer greazer added this to the June 2021 Release milestone Apr 22, 2021
@DonJayamanne
Copy link
Contributor

support it. The .NET team would do the work to expose those languages which in turn would be found by that API. Is that understanding correct?

Again to be clear, we don't need to do anything here, .NET team can make the necessary chanages without any dependency on us.

@claudiaregio
Copy link
Contributor Author

@DonJayamanne We were going to do this for us as well, only populate python, markdown, plain text + any magics python supports, am i not remembering correctly?

@DonJayamanne
Copy link
Contributor

Yes, you are correect, but wanted to ensure anyone looking at this issue that we're not blocking .NET

@rchiodo
Copy link
Contributor

rchiodo commented Jun 2, 2021

Tested with .NET interactive. Languages correctly switched back and forth

@rchiodo rchiodo closed this as completed Jun 2, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants