Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit languages in cell languages based on kernel #5895

Merged
merged 6 commits into from
May 14, 2021
Merged

Conversation

DonJayamanne
Copy link
Contributor

For #5580
Based on requirements from @claudiaregio

@DonJayamanne DonJayamanne requested a review from a team as a code owner May 14, 2021 16:35
@codecov-commenter
Copy link

codecov-commenter commented May 14, 2021

Codecov Report

Merging #5895 (e0f6998) into main (82b2b5b) will increase coverage by 0%.
The diff coverage is 87%.

❗ Current head e0f6998 differs from pull request most recent head 50f3896. Consider uploading reports for the commit 50f3896 to get more accurate results

@@          Coverage Diff           @@
##            main   #5895    +/-   ##
======================================
  Coverage     71%     72%            
======================================
  Files        403     403            
  Lines      26980   26990    +10     
  Branches    3939    3943     +4     
======================================
+ Hits       19318   19435   +117     
+ Misses      6049    5924   -125     
- Partials    1613    1631    +18     
Impacted Files Coverage Δ
...t/datascience/notebook/vscodeNotebookController.ts 77% <75%> (-1%) ⬇️
src/client/datascience/common.ts 89% <100%> (+<1%) ⬆️
src/client/datascience/constants.ts 99% <100%> (+<1%) ⬆️
src/client/datascience/kernel-launcher/types.ts 48% <0%> (-8%) ⬇️
src/client/common/errors/index.ts 69% <0%> (-4%) ⬇️
...rc/client/datascience/jupyter/debuggerVariables.ts 75% <0%> (-4%) ⬇️
...lient/datascience/kernel-launcher/kernelProcess.ts 72% <0%> (-3%) ⬇️
src/client/datascience/notebook/integration.ts 71% <0%> (-3%) ⬇️
src/client/common/utils/decorators.ts 77% <0%> (-1%) ⬇️
.../datascience/notebook/notebookControllerManager.ts 88% <0%> (-1%) ⬇️
... and 16 more

@DonJayamanne DonJayamanne merged commit fdee9dc into main May 14, 2021
@DonJayamanne DonJayamanne deleted the issue5580 branch May 14, 2021 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants