You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
IanMatthewHuff
changed the title
Fix final failing nonConda 'remote' test - Use same kernel when reopening
Allow for LiveKernels to be detected and added / removed as NotebookControllers
May 26, 2021
Looks like this is an actual functional issue that might take a bit of work.
When we connect to the remote machine we add our notebook kernels for installed kernels. But we also look for live running kernels. This test does the following:
Starts server
Starts a kernel with a document
Closes the document
Re-opens the document
Connects to the kernel that was previously left running
Runs a cell
But right now we only add NotebookControllers at first document open in the remote case.
There is a basic solution here, where on document open we just run our kernel finder again and addin anything missing from last time we ran it. This should pick up the new running kernels. However I did think that there might be an issue with the VS Code controller API where .dispose wouldn't remove a controller from the list. Will investigate.
When this work is done must turn back on and verify the test:
"Use same kernel when re-opening notebook"
I've also put this issue in a comment in the code.
The text was updated successfully, but these errors were encountered: