Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for LiveKernels to be detected and added / removed as NotebookControllers #5984

Closed
IanMatthewHuff opened this issue May 25, 2021 · 3 comments
Assignees

Comments

@IanMatthewHuff
Copy link
Member

image.png

@IanMatthewHuff IanMatthewHuff self-assigned this May 25, 2021
@IanMatthewHuff IanMatthewHuff changed the title Fix final failing nonConda 'remote' test - Use same kernel when reopening Allow for LiveKernels to be detected and added / removed as NotebookControllers May 26, 2021
@IanMatthewHuff
Copy link
Member Author

Looks like this is an actual functional issue that might take a bit of work.

When we connect to the remote machine we add our notebook kernels for installed kernels. But we also look for live running kernels. This test does the following:
Starts server
Starts a kernel with a document
Closes the document
Re-opens the document
Connects to the kernel that was previously left running
Runs a cell

But right now we only add NotebookControllers at first document open in the remote case.

There is a basic solution here, where on document open we just run our kernel finder again and addin anything missing from last time we ran it. This should pick up the new running kernels. However I did think that there might be an issue with the VS Code controller API where .dispose wouldn't remove a controller from the list. Will investigate.

@IanMatthewHuff
Copy link
Member Author

When this work is done must turn back on and verify the test:
"Use same kernel when re-opening notebook"
I've also put this issue in a comment in the code.

@rchiodo
Copy link
Contributor

rchiodo commented Jun 15, 2021

Validated

@rchiodo rchiodo closed this as completed Jun 15, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants