Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip failing test #5997

Merged
merged 2 commits into from
May 26, 2021
Merged

Skip failing test #5997

merged 2 commits into from
May 26, 2021

Conversation

IanMatthewHuff
Copy link
Member

I've added / updated issue #5984 to track fixing this. Disabling the test for now as I want things green. I don't believe the fix will be too hard, but skipipng for now to get our tests fixed up.

Luckily we had this test as it was exposing a real functional issue with kernel push.

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).

@IanMatthewHuff IanMatthewHuff requested a review from a team as a code owner May 26, 2021 18:26
@codecov-commenter
Copy link

codecov-commenter commented May 26, 2021

Codecov Report

Merging #5997 (37a7c83) into main (72a3cb1) will decrease coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main   #5997   +/-   ##
=====================================
- Coverage     72%     72%   -1%     
=====================================
  Files        403     403           
  Lines      27115   27115           
  Branches    3970    3970           
=====================================
- Hits       19592   19588    -4     
- Misses      5870    5875    +5     
+ Partials    1653    1652    -1     
Impacted Files Coverage Δ
...tascience/interactive-ipynb/trustCommandHandler.ts 50% <0%> (-13%) ⬇️
src/client/common/application/applicationShell.ts 19% <0%> (-5%) ⬇️
src/client/common/utils/decorators.ts 77% <0%> (-2%) ⬇️
.../datascience/notebook/notebookControllerManager.ts 86% <0%> (-2%) ⬇️
...ent/datascience/notebook/notebookEditorProvider.ts 81% <0%> (-2%) ⬇️
src/client/datascience/baseJupyterSession.ts 71% <0%> (-1%) ⬇️
src/client/datascience/raw-kernel/rawSocket.ts 86% <0%> (+1%) ⬆️
src/client/datascience/notebook/integration.ts 73% <0%> (+2%) ⬆️
...rc/client/datascience/jupyter/debuggerVariables.ts 78% <0%> (+3%) ⬆️
src/client/common/process/pythonDaemonPool.ts 80% <0%> (+4%) ⬆️

@IanMatthewHuff IanMatthewHuff merged commit 9d1b473 into main May 26, 2021
@IanMatthewHuff IanMatthewHuff deleted the dev/ianhu/fixLastRemoteTest branch May 26, 2021 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants