Restart kernel on Python interactive window does not actually restart kernel

[shaperilio]

Issue Type: Bug

Start a simple Python file:

# %%
x = 5
# %%
x

Shift+Enter on both blocks. Now Restart the kernel, and Shift+Enter second block - x is still defined (it should not be).

Extension version: 2021.8.2025984474
VS Code version: Code - Insiders 1.60.0-insider (7c25c174726ab969db3f99058cdf24bcfae1cfbe, 2021-08-11T05:15:24.598Z)
OS version: Windows_NT x64 10.0.19043
Restricted Mode: No

System Info

Item	Value
CPUs	AMD Ryzen 9 5950X 16-Core Processor (32 x 3400)
GPU Status	2d_canvas: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on oop_rasterization: enabled opengl: enabled_on rasterization: enabled skia_renderer: enabled_on video_decode: enabled vulkan: disabled_off webgl: enabled webgl2: enabled
Load (avg)	undefined
Memory (System)	63.92GB (52.79GB free)
Process Argv
Screen Reader	no
VM	0%

A/B Experiments

vsliv695:30137379
vsins829:30139715
vsliv368cf:30146710
vsreu685:30147344
python383cf:30185419
pythonvspyt602:30291494
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythonvspyt639:30291487
pythontb:30258533
pythonptprofiler:30281269
vshan820:30294714
pythondataviewer:30285072
pythonvsuse255:30319630
vscod805:30301674
pythonvspyt200:30323110
vsccppwt:30312692
pythonvssor306:30340298
bridge0708:30335490
pygetstartedt2:30349639
dockerwalkthrucf:30348714
javagetstartedt:30350119

[vscodebot]

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• Support notion of restarting Notebook kernels (#118783)

[rchiodo]

Thanks for the bug. Seems to be intermittent. I can get it to repro from a python file, but if I give focus to the IW, the restart sometimes works.

[joyceerhl]

@shaperilio How are you invoking the command to restart a kernel? This is possibly a duplicate of #6996

[shaperilio]

@joyceerhl I'm hitting the "restart" button in the top toolbar:

For me, it happens every time with (so far) every interactive window opened for each Python file

[joyceerhl]

Never mind, this is the same problem as #6983.

vscode-jupyter/src/client/datascience/jupyter/kernels/kernelExecution.ts

Lines 132 to 135 in f5c8929

	const executionQueue = this.documentExecutions.get(document);
	if (!executionQueue) {
	return;
	}

This will be properly addressed by #7067 but that's too risky to release in a recovery build; in the meantime I'll submit a hotfix in the style of #7070. Sorry for the trouble.

[shaperilio]

No trouble at all, thanks for working on it!

[joyceerhl]

Oh and as a temporary workaround you can configure "jupyter.enableNativeInteractiveWindow": false to temporarily opt out of the new interactive window experience which contains this issue.

[shaperilio]

Right; seems that VSCode needs to be restarted for that setting to take effect (but there's no warning as such).

[joyceerhl]

Fix should go out in the next recovery build #7084