Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish interactive window #7168

Closed
17 tasks done
joyceerhl opened this issue Aug 17, 2021 · 4 comments
Closed
17 tasks done

Polish interactive window #7168

joyceerhl opened this issue Aug 17, 2021 · 4 comments
Labels
bug Issue identified by VS Code Team member as probable bug interactive-window Impacts interactive window verified Verification succeeded

Comments

@joyceerhl
Copy link
Contributor

joyceerhl commented Aug 17, 2021

We shipped a native interactive window experience in the July release. This issue tracks polishing the interactive window experience.

Done

Upstream

Deferred

@joyceerhl joyceerhl added bug Issue identified by VS Code Team member as probable bug interactive-window Impacts interactive window labels Aug 17, 2021
@greazer greazer added this to the August 2021 milestone Aug 19, 2021
@ihnorton
Copy link

ihnorton commented Aug 20, 2021

Not sure if you want separate issue for this, but one helpful minor tweak would be to show the spinner/completion checkbox regardless of the number of lines of the input cell. Currently, when I send multiple cells to the interactive window at once (from a cell-delimited (#%%) script file), then each execution cell is displayed collapsed in the interactive windows. This makes it very difficult to tell whether execution has completed -- have to expand each cell to see the spinner/checkbox.

@thor4
Copy link

thor4 commented Aug 23, 2021

Thanks for this helpful list @joyceerhl. Should #7065 also be included here?

@joyceerhl
Copy link
Contributor Author

@ihnorton In the current Insiders build and upcoming Stable release, we will display a blue progress bar above each cell that is executing--this is the same progress bar that is displayed when the cell is expanded, and @rebornix pushed a change to ensure that the progress bar is also displayed when the cell is collapsed. Hopefully that is a slight improvement for now.

@thor4 #7065 was an existing issue with the variable explorer for native notebooks so should be addressed outside of this issue, which tracks interactive window-specific issues.

@joyceerhl
Copy link
Contributor Author

Will tackle https://github.com/microsoft/vscode/issues/130295 at the start of next iteration as it involves a somewhat risky refactor. All remaining issues are either upstream (discussing solutions with @rebornix) or fixed in Insiders.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2021
@greazer greazer modified the milestones: September 2021, October 2021 Sep 29, 2021
@greazer greazer added the verified Verification succeeded label Sep 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug interactive-window Impacts interactive window verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants